From: Shi Weihua <shiwh@cn.fujitsu.com>
To: subrata@linux.vnet.ibm.com
Cc: ltp-list <ltp-list@lists.sourceforge.net>
Subject: [LTP] [PATCH] eventfd01: should to check ret in overflow_poll_test()
Date: Thu, 06 May 2010 17:25:56 +0800 [thread overview]
Message-ID: <4BE28B24.1070801@cn.fujitsu.com> (raw)
We should to check the return value of trigger_eventfd_overflow()
in overflow_poll_test().
Signed-off-by: Shi Weihua <shiwh@cn.fujitsu.com>
---
diff --git a/testcases/kernel/syscalls/eventfd/eventfd01.c b/testcases/kernel/syscalls/eventfd/eventfd01.c
index 83eb86e..ce55746 100644
--- a/testcases/kernel/syscalls/eventfd/eventfd01.c
+++ b/testcases/kernel/syscalls/eventfd/eventfd01.c
@@ -602,7 +602,7 @@ static void overflow_poll_test(int evfd)
int ret;
ret = trigger_eventfd_overflow(evfd, &fd, &ctx);
- if (fd == -1) {
+ if (ret == -1) {
tst_resm(TBROK, "error triggering eventfd overflow");
return;
}
------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next reply other threads:[~2010-05-06 9:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-06 9:25 Shi Weihua [this message]
2010-05-06 18:01 ` [LTP] [PATCH] eventfd01: should to check ret in overflow_poll_test() Garrett Cooper
2010-05-07 5:46 ` Subrata Modak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE28B24.1070801@cn.fujitsu.com \
--to=shiwh@cn.fujitsu.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=subrata@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.