Re: [PATCH] KVM: make kvm_mmu_zap_page() return the number of pages it actually freed.

[Avi Kivity <avi@redhat.com>]

On 05/06/2010 12:25 PM, Gui Jianfeng wrote:
> Avi Kivity wrote:
>    
>> On 05/05/2010 04:03 AM, Gui Jianfeng wrote:
>>      
>>> Currently, kvm_mmu_zap_page() returning the number of freed children sp.
>>> This might confuse the caller, because caller don't know the actual freed
>>> number. Let's make kvm_mmu_zap_page() return the number of pages it
>>> actually
>>> freed.
>>>
>>>
>>>        
>>              if (kvm_mmu_zap_page(kvm, sp))
>>                  goto restart;
>>
>> Needs to be updated.
>>      
> Hi Avi,
>
> if kvm_mmu_zap_page() returns 1, we don't know whether the freed sp is the one we passes into
> or the child. So here just restart hash walk as long as kvm_mmu_zap_page() returning a positive
> number, although sometimes un-needed hash walk will happen. This fix gets code simpler, the
> idea comes from Marcelo.
>    

I see.  Note this can invoke quadratic behaviour.  I'll apply the patch, 
but we need to improve this area.

-- 
error compiling committee.c: too many arguments to function