All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: mtosatti@redhat.com, kvm@vger.kernel.org
Subject: Re: [PATCH RFC] KVM: inject #UD if instruction emulation fails while vcpu is in cpl==3
Date: Thu, 06 May 2010 15:48:16 +0300	[thread overview]
Message-ID: <4BE2BA90.3070909@redhat.com> (raw)
In-Reply-To: <20100506124104.GD24787@redhat.com>

On 05/06/2010 03:41 PM, Gleb Natapov wrote:
> On Thu, May 06, 2010 at 03:33:12PM +0300, Avi Kivity wrote:
>    
>> On 05/06/2010 03:25 PM, Gleb Natapov wrote:
>>      
>>>        
>>>> We can expect that from a developer or a user subscribed to kvm@.
>>>> But what about some random user running virt-manager?
>>>>
>>>>          
>>> What virt-manager would do about such error?
>>>        
>> Call up abrt.
>>
>>      
> The idea is not to let userspace process running in a VM kill the VM.
>    

Well, log the problem (including registers and instruction code), and 
continue with the #UD.

>>>> True.  But the same problem exists with cpl>0 #UD.  It may be a
>>>> critical driver in userspace (say, video driver).
>>>>
>>>> Also need to think consider nested kernels (which are userspace for
>>>> this purpose).
>>>>          
>>> Ugh, we can check if vcpu is in nested mode.
>>>        
>> And do what?  Inject #UD to the guest?  Or force some vmexit?
>>
>>      
> Does host emulator will ever run on behalf of nested guest? We have
> emulator inside nested guest for this.
>    

If the guest doesn't map the page, it will emulate.  If it does map the 
page, and the host doesn't, the host emulates.

-- 
error compiling committee.c: too many arguments to function


      reply	other threads:[~2010-05-06 12:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-29 11:58 [PATCH RFC] KVM: inject #UD if instruction emulation fails while vcpu is in cpl==3 Gleb Natapov
2010-05-06  9:15 ` Avi Kivity
2010-05-06 10:06   ` Gleb Natapov
2010-05-06 10:13     ` Avi Kivity
2010-05-06 12:25       ` Gleb Natapov
2010-05-06 12:33         ` Avi Kivity
2010-05-06 12:41           ` Gleb Natapov
2010-05-06 12:48             ` Avi Kivity [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BE2BA90.3070909@redhat.com \
    --to=avi@redhat.com \
    --cc=gleb@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.