From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gihan Munasinghe <GMunasinghe@flexiant.com>
Subject: Re: [PATCH] vncpassword support in libxl
Date: Thu, 06 May 2010 17:12:38 +0100
Message-ID: <4BE2EA76.4020005@flexiant.com>
References: <4BE2D9B9.8010908@flexiant.com>	<4BE2E434.6040001@flexiant.com>	<alpine.DEB.2.00.1005061701180.11380@kaball-desktop>
	<19426.59907.68893.972136@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <19426.59907.68893.972136@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

Ian Jackson wrote:
> Stefano Stabellini writes ("Re: [Xen-devel] [PATCH] vncpassword support in libxl"):
>   
>> The indentation is often wrong and sometimes you are adding\removing
>> blank lines for no reason.
>> But apart from this small cosmetic issues the patch looks good.
>>     
>
> You missed that he removed this line:
>
> -    printf("Parsing config file %s\n", config_file);
>
> This demonstrates why patches with spurious stuff in should be
> rejected - it's too easy to miss a mistake when scanning past a lot of
> spurious changes.
>
> Ian.
>
>
>   
Yes my mad will do the changes and resubmit again