All of lore.kernel.org
 help / color / mirror / Atom feed
From: Corey Minyard <minyard@acm.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
	OpenIPMI Developers <openipmi-developer@lists.sourceforge.net>,
	Matthew Garrett <mjg@redhat.com>,
	Myron Stowe <myron.stowe@hp.com>
Subject: Re: [PATCH 1/8] ipmi: Change addr_source to an enum rather than strings
Date: Thu, 06 May 2010 11:49:34 -0500	[thread overview]
Message-ID: <4BE2F31E.5020201@acm.org> (raw)
In-Reply-To: <20100504155356.57722519.akpm@linux-foundation.org>

Andrew Morton wrote:
> I already have three IPMI patches queued:
>
> http://userweb.kernel.org/~akpm/mmotm/broken-out/ipmi-raise-precedence-of-pnp-based-discovery-mechanisms-acpi-pci.patch
>   
I don't believe this patch is valid.  The discovery order in the patch 
from Matthew is the correct one, I believe.  So NACK on this one.

> http://userweb.kernel.org/~akpm/mmotm/broken-out/ipmi-convert-tracking-of-the-acpi-device-pointer-to-a-pnp-device.patch
>   
This should be good.

> http://userweb.kernel.org/~akpm/mmotm/broken-out/ipmi-update-driver-to-use-dev_printk-and-its-constructs.patch
>   
This is nice, I'll rework it and resend.

Thanks a bunch.

-corey

> The first two were repairable.  The third is now thoroughly trashed and
> needs redoing.
>
> I have no record of you having reviewed or [n]acked those three IPMI
> patches?
>
>   


      reply	other threads:[~2010-05-06 16:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-03 13:33 [PATCH 1/8] ipmi: Change addr_source to an enum rather than strings Corey Minyard
2010-05-04 22:53 ` Andrew Morton
2010-05-06 16:49   ` Corey Minyard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BE2F31E.5020201@acm.org \
    --to=minyard@acm.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg@redhat.com \
    --cc=myron.stowe@hp.com \
    --cc=openipmi-developer@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.