From: Benny Halevy <bhalevy@panasas.com>
To: andros@netapp.com
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH 0/5] Restore non-file layout code version 2
Date: Thu, 06 May 2010 22:47:22 +0300 [thread overview]
Message-ID: <4BE31CCA.1020004@panasas.com> (raw)
In-Reply-To: <1272652032-2496-1-git-send-email-andros@netapp.com>
On Apr. 30, 2010, 21:27 +0300, andros@netapp.com wrote:
> Applies to 2.6.34-rc5 pnfs-submit branch on top of the "pNFS generic devce ID
> cache version 3" and " Remove non-file layout code from submit tree version 2"
>
> This patch set restores object and block functionality removed in the
> pnfs-submit tree.
>
> Adjust to using the generic device id cache.
> Permanetly remove structure fields and function parameters not used by any
> layout driver.
>
> Note: struct nfs_server pnfs_mount_type pointer was removed as it was unused
> due to the generic deviceid cache. The file layout driver does not need a
> private data pointer in struct nfs_server, and currently, neither does the
> object nor block layout driver. Once code is submitted that needs a private
> data pointer, (as I'm told is on the way) we can add one.
>
> Note: The CB_NOTIFY_DEVICEID code is incomplete in that all layout segments
> referring to the 'to be removed device id' need to be reaped, and all in-flight
> I/O drained prior to device id removal.
> Note: The generic device id cache means that there is no longer any need for
> a per layout driver delete_deviceid call.
> 0001-pnfs_post_submit-restore-CB_NOTIFY_DEVICEID.patch
>
> For the block layout driver: Please review and test.
> Note: new getdevicelist layoutdriver_io_operation.
> 0002-pnfs_post_submit-restore-GETDEVICELIST.patch
> 0003-pnfs_post_submit-add-getdevicelist-io-operation.patch
Patches 1,2, 4,5 committed to the pnfs branch. Thanks!
Benny
>
> For the object layout driver. Please review and test.
> Note: Just removed the unused ds_wpages and ds_rpages.
> 0004-pnfs_post_submit-restore-ds_wsize-and-ds_rsize.patch
> 0005-pnfs_post_submit-restore-get_blocksize-policy-operat.patch
>
>
> Testing:
> -------
>
> The file layout driver does not use this code, so I could not test, and the
> code has changed due to the generic device id cache.
>
> I did run Connectathon to smoke test that the file layout functionality has not
> changed.
>
>
> -->Andy
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2010-05-06 19:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-30 18:27 [PATCH 0/5] Restore non-file layout code version 2 andros
2010-04-30 18:27 ` [PATCH 1/5] pnfs_post_submit: restore CB_NOTIFY_DEVICEID andros
2010-04-30 18:27 ` [PATCH 2/5] pnfs_post_submit: restore GETDEVICELIST andros
2010-04-30 18:27 ` [PATCH 3/5] pnfs_post_submit: add getdevicelist io operation andros
2010-04-30 18:27 ` [PATCH 4/5] pnfs_post_submit: restore ds_wsize and ds_rsize andros
2010-04-30 18:27 ` [PATCH 5/5] pnfs_post_submit: restore get_blocksize policy operation andros
2010-05-06 19:47 ` Benny Halevy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE31CCA.1020004@panasas.com \
--to=bhalevy@panasas.com \
--cc=andros@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.