From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jiri Slaby <jirislaby@gmail.com>
Subject: Re: [patch] i915: missing unlock on error path
Date: Fri, 07 May 2010 10:43:59 +0200
Message-ID: <4BE3D2CF.3090809@gmail.com>
References: <20100507083701.GW27064@bicker>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.sourceforge.net>
In-Reply-To: <20100507083701.GW27064@bicker>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=dri-devel>
List-Post: <mailto:dri-devel@lists.sourceforge.net>
List-Help: <mailto:dri-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.sourceforge.net?subject=subscribe>
Errors-To: dri-devel-bounces@lists.sourceforge.net
To: Dan Carpenter <error27@gmail.com>
Cc: =?ISO-8859-1?Q?Kristian_H=F8gsberg?= <krh@bitplanet.net>, David Airlie <airlied@linux.ie>, Jesse Barnes <jbarnes@virtuousgeek.org>, dri-devel@lists.sourceforge.net
List-Id: dri-devel@lists.freedesktop.org

On 05/07/2010 10:37 AM, Dan Carpenter wrote:
> There was a missing mutex_unlock(&dev->struct_mutex) on this error path.
> 
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> I thought Jiri sent this patch earlier but a google search for "stanse
> struct_mutex i965_reset" didn't find any patches, so I'm resending.

I don't remember either. I found I had only fixed potential NULL-deref
in i915_suspend.

> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 01e91ea..a605c87 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -369,6 +369,7 @@ int i965_reset(struct drm_device *dev, u8 flags)
>  		}
>  	} else {
>  		DRM_ERROR("Error occurred. Don't know how to reset this chip.\n");
> +		mutex_unlock(&dev->struct_mutex);
>  		return -ENODEV;
>  	}
>  


-- 
js

------------------------------------------------------------------------------

--