From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: [PATCH 1/2] x86: get the offset at compile time instead of raw value Date: Fri, 07 May 2010 16:51:26 +0800 Message-ID: <4BE3D48E.3010803@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org Get the offset form the struct instead of raw value Signed-off-by: Xiao Guangrong diff -r 632487ba7f63 -r 5ca49b1a6077 xen/arch/x86/boot/cmdline.S --- a/xen/arch/x86/boot/cmdline.S Fri May 07 22:48:33 2010 +0800 +++ b/xen/arch/x86/boot/cmdline.S Fri May 07 23:56:27 2010 +0800 @@ -147,10 +147,6 @@ 3: pop %ebx ret -/* multiboot_info structure offsets. */ -#define MB_flags 0 -#define MB_cmdline 16 - cmdline_parse_early: pusha diff -r 632487ba7f63 -r 5ca49b1a6077 xen/arch/x86/x86_32/asm-offsets.c --- a/xen/arch/x86/x86_32/asm-offsets.c Fri May 07 22:48:33 2010 +0800 +++ b/xen/arch/x86/x86_32/asm-offsets.c Fri May 07 23:56:27 2010 +0800 @@ -9,6 +9,7 @@ #include #include #include +#include #define DEFINE(_sym, _val) \ __asm__ __volatile__ ( "\n->" #_sym " %0 " #_val : : "i" (_val) ) @@ -127,4 +128,8 @@ BLANK(); OFFSET(CPUINFO_ext_features, struct cpuinfo_x86, x86_capability[1]); + BLANK(); + + OFFSET(MB_flags, multiboot_info_t, flags); + OFFSET(MB_cmdline, multiboot_info_t, cmdline); } diff -r 632487ba7f63 -r 5ca49b1a6077 xen/arch/x86/x86_64/asm-offsets.c --- a/xen/arch/x86/x86_64/asm-offsets.c Fri May 07 22:48:33 2010 +0800 +++ b/xen/arch/x86/x86_64/asm-offsets.c Fri May 07 23:56:27 2010 +0800 @@ -10,6 +10,7 @@ #include #include #include +#include #define DEFINE(_sym, _val) \ __asm__ __volatile__ ( "\n->" #_sym " %0 " #_val : : "i" (_val) ) @@ -151,4 +152,8 @@ BLANK(); OFFSET(CPUINFO_ext_features, struct cpuinfo_x86, x86_capability[1]); + BLANK(); + + OFFSET(MB_flags, multiboot_info_t, flags); + OFFSET(MB_cmdline, multiboot_info_t, cmdline); }