From: Nigel Cunningham <nigel@tuxonice.net>
To: Steven Liu <lingjiujianke@gmail.com>
Cc: Linus WALLEIJ <linus.walleij@stericsson.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Check kmalloc return value before use the buffer
Date: Fri, 07 May 2010 19:37:30 +1000 [thread overview]
Message-ID: <4BE3DF5A.9070601@tuxonice.net> (raw)
In-Reply-To: <z2mbd0d95d71005070017w7aa97001m2b81be6dbc1021b9@mail.gmail.com>
Hi.
No commit comment?
On 07/05/10 17:17, Steven Liu wrote:
> Signed-off-by: LiuQi<lingjiujianke@gmail.com>
> ---
> arch/arm/mach-u300/dummyspichip.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-u300/dummyspichip.c
> b/arch/arm/mach-u300/dummyspichip.c
> index 5f55012..df19f9b 100644
> --- a/arch/arm/mach-u300/dummyspichip.c
> +++ b/arch/arm/mach-u300/dummyspichip.c
> @@ -64,6 +64,11 @@ static ssize_t dummy_looptest(struct device *dev,
> goto out;
> }
> bigrxbuf_virtual = kmalloc(DMA_TEST_SIZE, GFP_KERNEL);
> + if (bigrxbuf_virtual == NULL) {
> + status = -ENOMEM;
> + kfree(bigtxbuf_virtual);
Why kfree something you know is NULL?
Regards,
Nigel
next prev parent reply other threads:[~2010-05-07 9:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 2:41 [PATCH] Check kmalloc return value before use the buffer Steven Liu
2010-05-07 6:52 ` Linus WALLEIJ
2010-05-07 7:16 ` Steven Liu
2010-05-07 7:17 ` Steven Liu
2010-05-07 9:37 ` Nigel Cunningham
2010-05-07 9:37 ` Nigel Cunningham [this message]
2010-05-07 9:47 ` Steven Liu
2010-05-07 9:51 ` Nigel Cunningham
2010-05-07 18:57 ` Linus WALLEIJ
2010-05-08 1:27 ` Nigel Cunningham
2010-05-08 8:56 ` Steven Liu
2010-05-07 9:50 ` Steven Liu
2010-05-07 9:52 ` Nigel Cunningham
2010-05-07 9:55 ` Steven Liu
2010-05-10 21:49 ` Andy Isaacson
2010-05-10 22:08 ` Nigel Cunningham
-- strict thread matches above, loose matches on Subject: below --
2010-05-07 9:05 Steven Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE3DF5A.9070601@tuxonice.net \
--to=nigel@tuxonice.net \
--cc=lingjiujianke@gmail.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.