From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Fitzhardinge Subject: Re: [Patch] support cpupool for xl create Date: Fri, 07 May 2010 14:57:27 -0700 Message-ID: <4BE48CC7.3050101@goop.org> References: <4BE3CBCA.7080104@ts.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4BE3CBCA.7080104@ts.fujitsu.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Juergen Gross Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 05/07/2010 01:14 AM, Juergen Gross wrote: > Hi, > > attached patch supports cpupool specification for xl create. This crashes for me: (gdb) run create /etc/xen/f13pv64 Starting program: /usr/sbin/xl create /etc/xen/f13pv64 [Thread debugging using libthread_db enabled] Parsing config file /etc/xen/f13pv64 Program received signal SIGSEGV, Segmentation fault. 0x00007ffff79cd805 in libxl_domain_make (ctx=0x60f8a0, info=0x7fffffffe0b0, domid=0x60f890) at libxl.c:172 172 xs_write(ctx->xsh, t, libxl_sprintf(ctx, "%s/pool_name", vm_path), info->poolname, strlen(info->poolname)); (gdb) p info->poolname $2 = 0x0 Adding diff -r bbf009817ffb tools/libxl/libxl.c --- a/tools/libxl/libxl.c Fri May 07 19:22:28 2010 +0100 +++ b/tools/libxl/libxl.c Fri May 07 14:57:00 2010 -0700 @@ -169,7 +169,8 @@ xs_write(ctx->xsh, t, libxl_sprintf(ctx, "%s/uuid", vm_path), uuid_string, strlen(uuid_string)); xs_write(ctx->xsh, t, libxl_sprintf(ctx, "%s/name", vm_path), info->name, strlen(info->name)); - xs_write(ctx->xsh, t, libxl_sprintf(ctx, "%s/pool_name", vm_path), info->poolname, strlen(info->poolname)); + if (info->poolname) + xs_write(ctx->xsh, t, libxl_sprintf(ctx, "%s/pool_name", vm_path), info->poolname, strlen(info->poolname)); libxl_xs_writev(ctx, t, dom_path, info->xsdata); libxl_xs_writev(ctx, t, libxl_sprintf(ctx, "%s/platform", dom_path), info->platformdata); fixes it for me. J