[Qemu-devel] vmstate: Useless post_save?

[Jan Kiszka <jan.kiszka@web.de>]

[-- Attachment #1: Type: text/plain, Size: 614 bytes --]

Hi all,

I wondered why we have the post_save callback in vmstate. Conceptually,
it made no sense to me. So I grep'ed for its users - and found exactly
one: tmp105. As suspected, only "strange" code was found:

static void tmp105_post_save(void *opaque)
{
    TMP105State *s = opaque;
    s->faults = tmp105_faultq[(s->config >> 3) & 3];            /* F */
}

First, s->config cannot be changed by saving the state. And, second,
s->faults is only written by this driver, never read.

Anyone any concerns dropping 'faults' from tmp105 and then dropping the
post_save handler from vmstate?

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]