From: "H. Peter Anvin" <hpa@zytor.com>
To: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
greg@kroah.com, hjanssen@microsoft.com, ksrinivasan@novell.com,
dtor@vmware.com, tglx@linutronix.de, akataria@vmware.com
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/cpu] Modify the VMware balloon driver for the new x86_hyper API
Date: Sun, 09 May 2010 01:20:44 -0700 [thread overview]
Message-ID: <4BE6705C.3000206@zytor.com> (raw)
In-Reply-To: <tip-a10a569806e43b9be5fce60b21f836b50b1010e4@git.kernel.org>
On 05/09/2010 01:19 AM, tip-bot for H. Peter Anvin wrote:
>
> MODULE_AUTHOR("VMware, Inc.");
> MODULE_DESCRIPTION("VMware Memory Control (Balloon) Driver");
> @@ -767,7 +767,7 @@ static int __init vmballoon_init(void)
> * Check if we are running on VMware's hypervisor and bail out
> * if we are not.
> */
> - if (!vmware_platform())
> + if (x86_hyper != &x86_hyper_vmware)
> return -ENODEV;
>
> vmballoon_wq = create_freezeable_workqueue("vmmemctl");
Note: I did not change the existing code, but this is an example of a
very common bug: the appropriate error code for "hardware is not
present" is ENXIO, not ENODEV.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2010-05-09 8:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 22:43 RFC - Cleaned up hypervisor layer H. Peter Anvin
2010-05-07 23:02 ` Greg KH
2010-05-07 23:08 ` H. Peter Anvin
2010-05-07 23:12 ` Greg KH
2010-05-07 23:18 ` H. Peter Anvin
2010-05-07 23:55 ` [PATCH] HyperV: fix up the license to mshyperv.c Greg KH
2010-05-08 1:58 ` [tip:x86/cpu] x86, " tip-bot for Greg Kroah-Hartman
2010-05-08 1:58 ` [tip:x86/cpu] x86: Clean up the hypervisor layer tip-bot for H. Peter Anvin
2010-05-08 8:16 ` Ingo Molnar
2010-05-19 16:54 ` [PATCH] Hyperv: Export the symbol that tracks hyperv features and recommendations Ky Srinivasan
2010-05-19 17:03 ` Greg KH
2010-05-08 5:54 ` RFC - Cleaned up hypervisor layer Dmitry Torokhov
2010-05-09 8:18 ` [tip:x86/cpu] x86, hypervisor: Export the x86_hyper* symbols tip-bot for H. Peter Anvin
2010-05-09 8:19 ` [tip:x86/cpu] Modify the VMware balloon driver for the new x86_hyper API tip-bot for H. Peter Anvin
2010-05-09 8:20 ` H. Peter Anvin [this message]
2010-05-10 8:06 ` Dmitry Torokhov
2010-05-10 15:23 ` H. Peter Anvin
2010-05-10 16:17 ` Dmitry Torokhov
2010-05-10 17:30 ` H. Peter Anvin
2010-05-10 17:52 ` Dmitry Torokhov
2010-05-10 18:05 ` H. Peter Anvin
2010-05-09 10:47 ` Ingo Molnar
2010-05-10 5:56 ` [tip:x86/cpu] x86, hypervisor: add missing <linux/module.h> tip-bot for H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE6705C.3000206@zytor.com \
--to=hpa@zytor.com \
--cc=akataria@vmware.com \
--cc=dtor@vmware.com \
--cc=greg@kroah.com \
--cc=hjanssen@microsoft.com \
--cc=ksrinivasan@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.