From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1OB7dP-0001Wb-BB
	for mharc-grub-devel@gnu.org; Sun, 09 May 2010 10:37:35 -0400
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1OB7dN-0001Vo-Pe
	for grub-devel@gnu.org; Sun, 09 May 2010 10:37:33 -0400
Received: from [140.186.70.92] (port=44804 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OB7dM-0001VI-C2
	for grub-devel@gnu.org; Sun, 09 May 2010 10:37:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <Christian.Franke@t-online.de>) id 1OB7dL-0006Lf-8u
	for grub-devel@gnu.org; Sun, 09 May 2010 10:37:32 -0400
Received: from mailout08.t-online.de ([194.25.134.20]:38838)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <Christian.Franke@t-online.de>) id 1OB7dK-0006LA-H0
	for grub-devel@gnu.org; Sun, 09 May 2010 10:37:31 -0400
Received: from fwd06.aul.t-online.de (fwd06.aul.t-online.de )
	by mailout08.t-online.de with smtp 
	id 1OB7dH-0000XA-0b; Sun, 09 May 2010 16:37:27 +0200
Received: from [192.168.2.100]
	(E4MH2mZ-Zh617cJpT5-S97PlywqONQ3iz6Fqrork3zehlQNkYvAWDyTeIg79JATZL-@[79.224.122.160])
	by fwd06.aul.t-online.de
	with esmtp id 1OB7d3-28Tzua0; Sun, 9 May 2010 16:37:13 +0200
Message-ID: <4BE6C898.4070704@t-online.de>
Date: Sun, 09 May 2010 16:37:12 +0200
From: Christian Franke <Christian.Franke@t-online.de>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
	rv:1.9.1.9) Gecko/20100317 SeaMonkey/2.0.4
MIME-Version: 1.0
To: The development of GNU GRUB <grub-devel@gnu.org>
References: <4BE1D239.8090207@t-online.de> <4BE6B89F.1020406@gmail.com>
In-Reply-To: <4BE6B89F.1020406@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-ID: E4MH2mZ-Zh617cJpT5-S97PlywqONQ3iz6Fqrork3zehlQNkYvAWDyTeIg79JATZL-
X-TOI-MSGID: 60980afb-1bbd-4a20-986f-d2fa7163138e
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3)
Subject: Re: [PATCH] Fix grub.d/10_windows for Cygwin 1.7
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GNU GRUB <grub-devel@gnu.org>
List-Id: The development of GNU GRUB <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 09 May 2010 14:37:34 -0000

Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> Christian Franke wrote:
>    
>> This change is already included in Cygwin package grub-1.98-2.
>>
>>      
> -
> +  test -z "$needmap" || cat<<EOF
> +	drivemap -s (hd0) \$root
> +EOF
> You can't be sure on script runtime that C: is on hd0. Ironically especially when drivemap is used.
> But drivemap -s (hd0) (hd0) is a nop, so no harm done.
> On the other hand Vista and 7 are incompatible with drivemap so you have to skip drivemap on those systems. Look at 30_os-prober.in:
>        case ${LONGNAME} in
>          Windows\ Vista*|Windows\ 7*)
>          ;;
>          *)
>            cat<<  EOF
>          drivemap -s (hd0) \${root}
> EOF
>          ;;
>        esac
>    

This is already considered in the script: $needmap is set if ntldr is 
found but not if bootmgr is found.


-- 
Regards,
Christian Franke