Re: [Patch] support cpupool for xl create

[Juergen Gross <juergen.gross@ts.fujitsu.com>]

[-- Attachment #1: Type: text/plain, Size: 2095 bytes --]

On 05/07/2010 11:57 PM, Jeremy Fitzhardinge wrote:
> On 05/07/2010 01:14 AM, Juergen Gross wrote:
>> Hi,
>>
>> attached patch supports cpupool specification for xl create.
>
> This crashes for me:
>
> (gdb) run create /etc/xen/f13pv64
> Starting program: /usr/sbin/xl create /etc/xen/f13pv64
> [Thread debugging using libthread_db enabled]
> Parsing config file /etc/xen/f13pv64
>
> Program received signal SIGSEGV, Segmentation fault.
> 0x00007ffff79cd805 in libxl_domain_make (ctx=0x60f8a0, info=0x7fffffffe0b0,
>      domid=0x60f890) at libxl.c:172
> 172	    xs_write(ctx->xsh, t, libxl_sprintf(ctx, "%s/pool_name", vm_path), info->poolname, strlen(info->poolname));
> (gdb) p info->poolname
> $2 = 0x0
>
> Adding
>
> diff -r bbf009817ffb tools/libxl/libxl.c
> --- a/tools/libxl/libxl.c	Fri May 07 19:22:28 2010 +0100
> +++ b/tools/libxl/libxl.c	Fri May 07 14:57:00 2010 -0700
> @@ -169,7 +169,8 @@
>
>       xs_write(ctx->xsh, t, libxl_sprintf(ctx, "%s/uuid", vm_path), uuid_string, strlen(uuid_string));
>       xs_write(ctx->xsh, t, libxl_sprintf(ctx, "%s/name", vm_path), info->name, strlen(info->name));
> -    xs_write(ctx->xsh, t, libxl_sprintf(ctx, "%s/pool_name", vm_path), info->poolname, strlen(info->poolname));
> +    if (info->poolname)
> +        xs_write(ctx->xsh, t, libxl_sprintf(ctx, "%s/pool_name", vm_path), info->poolname, strlen(info->poolname));
>
>       libxl_xs_writev(ctx, t, dom_path, info->xsdata);
>       libxl_xs_writev(ctx, t, libxl_sprintf(ctx, "%s/platform", dom_path), info->platformdata);
>
> fixes it for me.

You seem to have specified a not existing cpupool.
The solution should not be to ignore this, but to do a proper test on the
pool parameter.
Attached patch does this.


Juergen

-- 
Juergen Gross                 Principal Developer Operating Systems
TSP ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@ts.fujitsu.com
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html

[-- Attachment #2: libxl-poolerr.patch --]
[-- Type: text/x-patch, Size: 779 bytes --]

Signed-off-by: juergen.gross@ts.fujitsu.com

diff -r bbf009817ffb tools/libxl/xl_cmdimpl.c
--- a/tools/libxl/xl_cmdimpl.c	Fri May 07 19:22:28 2010 +0100
+++ b/tools/libxl/xl_cmdimpl.c	Mon May 10 08:01:03 2010 +0200
@@ -453,9 +453,15 @@ static void parse_config_data(const char
     if (!xlu_cfg_get_long(config, "oos", &l))
         c_info->oos = l;
 
-    if (!xlu_cfg_get_string (config, "pool", &buf))
+    if (!xlu_cfg_get_string (config, "pool", &buf)) {
+        c_info->poolid = -1;
         pool_qualifier_to_poolid(buf, &c_info->poolid, NULL);
+    }
     c_info->poolname = libxl_poolid_to_name(&ctx, c_info->poolid);
+    if (!c_info->poolname) {
+        fprintf(stderr, "Illegal pool specified\n");
+        exit(1);
+    }
 
     init_build_info(b_info, c_info);
 

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel