From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Fitzhardinge Subject: Re: [Patch] support cpupool for xl create Date: Sun, 09 May 2010 23:42:58 -0700 Message-ID: <4BE7AAF2.50906@goop.org> References: <4BE3CBCA.7080104@ts.fujitsu.com> <4BE48CC7.3050101@goop.org> <4BE7A22C.8020100@ts.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4BE7A22C.8020100@ts.fujitsu.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Juergen Gross Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 05/09/2010 11:05 PM, Juergen Gross wrote: >> diff -r bbf009817ffb tools/libxl/libxl.c >> --- a/tools/libxl/libxl.c Fri May 07 19:22:28 2010 +0100 >> +++ b/tools/libxl/libxl.c Fri May 07 14:57:00 2010 -0700 >> @@ -169,7 +169,8 @@ >> >> xs_write(ctx->xsh, t, libxl_sprintf(ctx, "%s/uuid", vm_path), >> uuid_string, strlen(uuid_string)); >> xs_write(ctx->xsh, t, libxl_sprintf(ctx, "%s/name", vm_path), >> info->name, strlen(info->name)); >> - xs_write(ctx->xsh, t, libxl_sprintf(ctx, "%s/pool_name", >> vm_path), info->poolname, strlen(info->poolname)); >> + if (info->poolname) >> + xs_write(ctx->xsh, t, libxl_sprintf(ctx, "%s/pool_name", >> vm_path), info->poolname, strlen(info->poolname)); >> >> libxl_xs_writev(ctx, t, dom_path, info->xsdata); >> libxl_xs_writev(ctx, t, libxl_sprintf(ctx, "%s/platform", >> dom_path), info->platformdata); >> >> fixes it for me. > > > You seem to have specified a not existing cpupool. > The solution should not be to ignore this, but to do a proper test on the > pool parameter. > Attached patch does this. I'm not using cpupools. My config makes no mention of "pool" at all. J