From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Gross Subject: Re: [Patch] support cpupool for xl create Date: Mon, 10 May 2010 08:58:39 +0200 Message-ID: <4BE7AE9F.2090900@ts.fujitsu.com> References: <4BE3CBCA.7080104@ts.fujitsu.com> <4BE48CC7.3050101@goop.org> <4BE7A22C.8020100@ts.fujitsu.com> <4BE7AAF2.50906@goop.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4BE7AAF2.50906@goop.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jeremy Fitzhardinge Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 05/10/2010 08:42 AM, Jeremy Fitzhardinge wrote: > On 05/09/2010 11:05 PM, Juergen Gross wrote: >>> diff -r bbf009817ffb tools/libxl/libxl.c >>> --- a/tools/libxl/libxl.c Fri May 07 19:22:28 2010 +0100 >>> +++ b/tools/libxl/libxl.c Fri May 07 14:57:00 2010 -0700 >>> @@ -169,7 +169,8 @@ >>> >>> xs_write(ctx->xsh, t, libxl_sprintf(ctx, "%s/uuid", vm_path), >>> uuid_string, strlen(uuid_string)); >>> xs_write(ctx->xsh, t, libxl_sprintf(ctx, "%s/name", vm_path), >>> info->name, strlen(info->name)); >>> - xs_write(ctx->xsh, t, libxl_sprintf(ctx, "%s/pool_name", >>> vm_path), info->poolname, strlen(info->poolname)); >>> + if (info->poolname) >>> + xs_write(ctx->xsh, t, libxl_sprintf(ctx, "%s/pool_name", >>> vm_path), info->poolname, strlen(info->poolname)); >>> >>> libxl_xs_writev(ctx, t, dom_path, info->xsdata); >>> libxl_xs_writev(ctx, t, libxl_sprintf(ctx, "%s/platform", >>> dom_path), info->platformdata); >>> >>> fixes it for me. >> >> >> You seem to have specified a not existing cpupool. >> The solution should not be to ignore this, but to do a proper test on the >> pool parameter. >> Attached patch does this. > > I'm not using cpupools. My config makes no mention of "pool" at all. Strange. I tested this case and it worked for me. Are you sure you have all actual patches installed? Could you try "xl create -d" and look for the cpupool settings? Juergen -- Juergen Gross Principal Developer Operating Systems TSP ES&S SWE OS6 Telephone: +49 (0) 89 3222 2967 Fujitsu Technology Solutions e-mail: juergen.gross@ts.fujitsu.com Domagkstr. 28 Internet: ts.fujitsu.com D-80807 Muenchen Company details: ts.fujitsu.com/imprint.html