All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yang Hongyang <yanghy@cn.fujitsu.com>
To: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: [PATCH]xl: Remove transaction handle in "xl rename"
Date: Mon, 10 May 2010 16:07:01 +0800	[thread overview]
Message-ID: <4BE7BEA5.4050809@cn.fujitsu.com> (raw)

Remove transaction handle in "xl rename"
Thanks Stefano to point out that transaction handle in libxl clients
is not needed.

Signed-off-by: Yang Hongyang <yanghy@cn.fujitsu.com>

diff -r bbf009817ffb tools/libxl/xl_cmdimpl.c
--- a/tools/libxl/xl_cmdimpl.c	Fri May 07 19:22:28 2010 +0100
+++ b/tools/libxl/xl_cmdimpl.c	Tue May 11 00:03:52 2010 +0800
@@ -3072,7 +3072,6 @@
     int opt;
     char *dom;
     char *new_name;
-    xs_transaction_t t;
 
     while ((opt = getopt(argc, argv, "h")) != -1) {
         switch (opt) {
@@ -3095,16 +3094,10 @@
     find_domain(dom);
     new_name = argv[optind];
 
-retry_transaction:
-    t = xs_transaction_start(ctx.xsh);
-    if (libxl_domain_rename(&ctx, domid, common_domname, new_name, t)) {
+    if (libxl_domain_rename(&ctx, domid, common_domname, new_name, 0)) {
         fprintf(stderr, "Can't rename domain '%s'.\n", dom);
         exit(1);
     }
 
-    if (!xs_transaction_end(ctx.xsh, t, 0))
-        if (errno == EAGAIN)
-            goto retry_transaction;
-
     exit(0);
 }

-- 
Regards
Yang Hongyang

                 reply	other threads:[~2010-05-10  8:07 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BE7BEA5.4050809@cn.fujitsu.com \
    --to=yanghy@cn.fujitsu.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.