From: Johannes Sixt <j.sixt@viscovery.net>
To: Sverre Rabbelier <srabbelier@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Tay Ray Chuan <rctay89@gmail.com>
Subject: Re: [PATCH] Fix a false negative in t5512 when run using sh -x
Date: Mon, 10 May 2010 12:23:52 +0200 [thread overview]
Message-ID: <4BE7DEB8.5000900@viscovery.net> (raw)
In-Reply-To: <AANLkTilaZlku8eQpAjMPCPkzeVyg2u21KOcsZkxn4Kxd@mail.gmail.com>
Am 5/10/2010 11:09, schrieb Sverre Rabbelier:
> On Mon, May 10, 2010 at 09:19, Johannes Sixt <j6t@kdbg.org> wrote:
>> Use 'grep' to check for expected output.
>
> Don't we do this ('test_cmp' on expected output) in many other places
> as well? Why is this different?
This is really only special because the test_cmp looked at the stderr of a
test_must_fail command. The old code was:
test_must_fail git ls-remote refs*master >actual 2>&1 &&
test_cmp exp actual
With bash, 'actual' contained:
++ git ls-remote 'refs*master'
fatal: 'refs*master' does not appear to be a git repository
fatal: The remote end hung up unexpectedly
++ test 128 -gt 0 -a 128 -le 129 -o 128 -gt 192
i.e., there were command traces in the file.
-- Hannes
next prev parent reply other threads:[~2010-05-10 10:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-10 7:19 [PATCH] Fix a false negative in t5512 when run using sh -x Johannes Sixt
2010-05-10 7:28 ` Tay Ray Chuan
2010-05-10 9:09 ` Sverre Rabbelier
2010-05-10 10:23 ` Johannes Sixt [this message]
2010-05-10 10:45 ` Sverre Rabbelier
2010-05-10 10:34 ` Jonathan Nieder
2010-05-10 11:03 ` Johannes Sixt
2010-05-10 11:31 ` Jonathan Nieder
2010-05-10 11:34 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE7DEB8.5000900@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=rctay89@gmail.com \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.