From: Sergei Shtylyov <sshtylyov@mvista.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] Support for devices with FAT32 PBR
Date: Mon, 10 May 2010 14:47:31 +0400 [thread overview]
Message-ID: <4BE7E443.60506@mvista.com> (raw)
In-Reply-To: <1273486456-10089-1-git-send-email-iluri@aotek.es>
Hello.
Igor Luri wrote:
> Signed-off-by: Igor Luri <iluri@aotek.es>
> ---
> disk/part_dos.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/disk/part_dos.c b/disk/part_dos.c
> index 887b75e..d91f773 100644
> --- a/disk/part_dos.c
> +++ b/disk/part_dos.c
> @@ -77,7 +77,8 @@ static int test_block_type(unsigned char *buffer)
> (buffer[DOS_PART_MAGIC_OFFSET + 1] != 0xaa) ) {
> return (-1);
> } /* no DOS Signature at all */
> - if(strncmp((char *)&buffer[DOS_PBR_FSTYPE_OFFSET],"FAT",3)==0)
> + if((strncmp((char *)&buffer[DOS_PBR_FSTYPE_OFFSET],"FAT",3)==0) ||
> + (strncmp((char *)&buffer[DOS_PBR_FAT32_FSTYPE_OFFSET],"FAT32",5)==0) )
>
You #define DOS_PBR_FAT32_FSTYPE_OFFSET only in patch 2. That way,
patch 1 is uncompilable. Merge the patches please.
WBR, Sergei
prev parent reply other threads:[~2010-05-10 10:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-10 10:14 [U-Boot] [PATCH 1/3] Support for devices with FAT32 PBR Igor Luri
2010-05-10 10:14 ` [U-Boot] [PATCH 2/3] " Igor Luri
2010-05-10 10:14 ` [U-Boot] [PATCH 3/3] " Igor Luri
2010-05-10 10:47 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE7E443.60506@mvista.com \
--to=sshtylyov@mvista.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.