From: Patrick McHardy <kaber@trash.net>
To: Jiri Pirko <jpirko@redhat.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH net-next-2.6] net: adjust handle_macvlan to pass port struct to hook
Date: Mon, 10 May 2010 16:35:34 +0200 [thread overview]
Message-ID: <4BE819B6.3020101@trash.net> (raw)
In-Reply-To: <20100506113352.GB3406@psychotron.lab.eng.brq.redhat.com>
Jiri Pirko wrote:
> Now there's null check here and also again in the hook. Looking at bridge bits
> which are simmilar, port structure is rcu_dereferenced right away in
> handle_bridge and passed to hook. Looks nicer.
>
> Signed-off-by: Jiri Pirko <jpirko@redhat.com>
Looks fine, thanks.
Acked-by: Patrick McHardy <kaber@trash.net>
next prev parent reply other threads:[~2010-05-10 14:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-06 11:33 [PATCH net-next-2.6] net: adjust handle_macvlan to pass port struct to hook Jiri Pirko
2010-05-10 14:35 ` Patrick McHardy [this message]
2010-05-16 6:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE819B6.3020101@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=jpirko@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.