Re: [PATCH] iptables: optionally disable largefile support.

[Patrick McHardy <kaber@trash.net>]

Jan Engelhardt wrote:
> On Monday 2010-05-10 17:25, Patrick McHardy wrote:
> 
>> Karl Hiramoto wrote:
>>> On 05/10/2010 10:00 AM, Jan Engelhardt wrote:
>>>> What is the actual problem you are experiencing? If the toolchain does
>>>> not support largefiles, the -D macros should not do anything, so that
>>>> conversely, their presence is not harmful.
>>>>    
>>> Uclibc include headers do checking see:
>>>
>>> http://git.uclibc.org/uClibc/tree/include/features.h#n216
>>>
>>>
>>> You get errors like:
>>>
>>>
>>> usr/include/features.h:383:4: error: #error It appears you have defined
>>> _FILE_OFFSET_BITS=64. Unfortunately, uClibc was built without large file
>>> support enabled.
>>> In file included from /build_armeb/staging_dir/usr/include/stdio.h:72,
>>>                  from libiptc/libip4tc.c:18:
>>> /build_armeb/staging_dir/usr/include/bits/uClibc_stdio.h:72:2: error:
>>> #error Sorry... uClibc was built without large file support!
>>> In file included from libiptc/libip4tc.c:18:
>>> /build_armeb/staging_dir/usr/include/stdio.h:83: error: expected '=',
>>> ',', ';', 'asm' or '__attribute__' before 'fpos_t'
>>> In file included from libiptc/libip4tc.c:18:
>>> /build_armeb/staging_dir/usr/include/stdio.h:709: error: expected
>>> declaration specifiers or '...' before 'fpos_t'
>>> /build_armeb/staging_dir/usr/include/stdio.h:711: error: expected ';',
>>> ',' or ')' before '*' token
>>>
>>>
>>> With this patch everything compiles and works fine.
>> Thanks for the explanation. Jan, can I assume you're OK with this patch?
> 
> Yeah. Time to bugger uclibc now :-)

Applies, thanks everyone.