Re: [Qemu-devel] [RFC][MIPS][PATCH 1/6] Initial support of bonito north bridge used by fulong mini pc

[Stefan Weil <weil@mail.berlios.de>]

Am 10.05.2010 13:21, schrieb chen huacai:
>>> --- a/hw/mips.h
>>> +++ b/hw/mips.h
>>> @@ -5,6 +5,9 @@
>>>  /* gt64xxx.c */
>>>  PCIBus *pci_gt64120_init(qemu_irq *pic);
>>>
>>> +/* bonito.c */
>>> +PCIBus *bonito_init_2e(qemu_irq pic);
>>> +
>>>  /* ds1225y.c */
>>>  void *ds1225y_init(target_phys_addr_t mem_base, const char *filename);
>>>  void ds1225y_set_protection(void *opaque, int protection);
>>> -----
>>>
>>
>> Please see my annotations above.
>>
>> Kind regards,
>> Stefan Weil
>>
>
> Hi, Stefan, do you means that I should do something like this?
>
> #ifdef CONFIG_FULONG
> /* bonito.c */
> PCIBus *bonito_init_2e(qemu_irq pic);
> #endif

You don't need CONFIG_FULONG here, because you may declare
bonito_init_2e even if it not used.

By the way: why is it called bonito_init_2e (and not bonito_2e_init)?

>
> I found that even if I put CONFIG_FULONG=y in
> default-configs/mips64el-softmmu.mak, CONFIG_FULONG will not get
> defined in config-target.h.
> Because CONFIG_FULONG=y will appear config-device.mak, but not
> config-target.mak.
> Could you please give me some suggestions?

CONFIG_FULONG is only used in Makefile.target for the
object files which are only needed for fulong. You could also
use a CONFIG_XXX for each individual device XXX, for example

CONFIG_VT82C686=y (indefault-configs/mips64el-softmmu.mak)
obj-mips-$(CONFIG_VT82C686) += vt82c686.o (in Makefile.target)


CONFIG_FULONG is not used in your source code,
so it is not needed in config-target.h.

Kind regards,
Stefan Weil