All of lore.kernel.org
 help / color / mirror / Atom feed
From: Henrik Rydberg <rydberg@euromail.se>
To: "Éric Piel" <E.A.B.Piel@tudelft.nl>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Florian Ragwitz <rafl@debian.org>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Subject: Re: [PATCH 2/2 v3] elantech: Report multitouch with proper ABS_MT messages
Date: Mon, 10 May 2010 22:53:49 +0200	[thread overview]
Message-ID: <4BE8725D.1060703@euromail.se> (raw)
In-Reply-To: <4BE86886.2080909@tudelft.nl>

Hi again Éric,

thanks for your changes, the first patch looks better now. However, both patches
still have style problems. Also, the second patch now makes unrelated changes to
the ABS_X etc, so it is difficult to even know what was tested, and whether the
first patch really works as claimed.

Henrik

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2010-05-10 20:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-08 16:39 [PATCH 2/2 v2] elantech: Report multitouch with proper ABS_MT messages Éric Piel
2010-05-10 20:11 ` [PATCH 2/2 v3] " Éric Piel
2010-05-10 20:53   ` Henrik Rydberg [this message]
2010-05-10 22:27     ` Éric Piel
2010-05-10 23:58       ` Henrik Rydberg
2010-05-11  0:11         ` Dmitry Torokhov
2010-05-11  0:48           ` Henrik Rydberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BE8725D.1060703@euromail.se \
    --to=rydberg@euromail.se \
    --cc=E.A.B.Piel@tudelft.nl \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=rafl@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.