Re: [PATCH] [OOPS] apbuart.c: Two problems related to grlib_apbuart_configure()

[Kristoffer Glembo <kristoffer@gaisler.com>]

Miguel Ojeda wrote:
> On Sat, May 8, 2010 at 11:58 PM, Miguel Ojeda
> <miguel.ojeda.sandonis@gmail.com> wrote:
>> Hi,
>>
>> I found two problems using the Simics' sunfire target, so maybe the
>> following does not occur in real machines.
>>
>> 1. At grlib_apbuart_configure() in apbuart.c, prop can be NULL if
>> "clock-frequency" doesn't exist in the OF tree:
>>
>>        /* Get bus frequency */
>>        rp = of_find_node_by_path("/");
>>        rp = of_get_next_child(rp, NULL);
>>        prop = of_get_property(rp, "clock-frequency", NULL);
>>        freq_khz = *prop;
>>
>> 2. In addition, apbuart.c does not check if there aren't any ports
>> configured after calls to grlib_apbuart_configure(), so other oops will
>> occur if no port was configured (e.g. uart_set_options() because of
>> port->ops).
>>
>> In order to solve that, I added a check after both of the calls to
>> grlib_apbuart_configure().
>>
>> The patch that I provide below prevents both problems in the Simics'
>> sunfire target.
>>
>> Tested against 2.6.33.3. Please review.
>>
>> Signed-off-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>


Thanks for the patch, it looks fine to me. 

Acked-by: Kristoffer Glembo <kristoffer@gaisler.com>