From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Weil <weil@mail.berlios.de>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] block/vpc: Fix conversion from size to disk geometry
Date: Tue, 11 May 2010 11:46:31 +0200 [thread overview]
Message-ID: <4BE92777.5040008@redhat.com> (raw)
In-Reply-To: <1273520786-10385-1-git-send-email-weil@mail.berlios.de>
Am 10.05.2010 21:46, schrieb Stefan Weil:
> The VHD algorithm calculates a disk geometry
> which is usually smaller than the requested size.
>
> QEMU tried to round up but failed for certain sizes:
>
> qemu-img create -f vpc disk.vpc 9437184
> would create an image with 9435136 bytes
> (which is too small for qemu-img convert).
>
> Instead of hacking the geometry algorithm, the patch
> increases the number of sectors until we get enough
> sectors.
>
> Cc: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2010-05-11 9:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-10 19:46 [Qemu-devel] [PATCH] block/vpc: Fix conversion from size to disk geometry Stefan Weil
2010-05-11 9:46 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE92777.5040008@redhat.com \
--to=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=weil@mail.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.