From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 4/4 v3] KVM: VMX: VMXON/VMXOFF usage changes. Date: Tue, 11 May 2010 12:50:21 +0300 Message-ID: <4BE9285D.6070006@redhat.com> References: <4BE91DEF.3080903@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "kvm@vger.kernel.org" , Marcelo Tosatti , Alexander Graf To: "Xu, Dongxiao" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:37004 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756693Ab0EKJuc (ORCPT ); Tue, 11 May 2010 05:50:32 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 05/11/2010 12:38 PM, Xu, Dongxiao wrote: > >> I'm not sure why this is needed. vmx_cpuid_update() is called from a >> vcpu ioctl which should have called vcpu_load() before. >> >> Apart from that, everything looks good for merging. >> > Vcpu_load() and vcpu_put() is not called in that ioctl. I will add that and > send out another version of patchset. > That's a serious bug even before this patchset, since vmx_cpuid_update accesses the vmcs. Please send the fix as a separate patch (which will be backported to -stable). -- error compiling committee.c: too many arguments to function