All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 11/11] netfilter: xtables: convert basic nfproto match functions into xt matches
Date: Tue, 11 May 2010 14:59:02 +0200	[thread overview]
Message-ID: <4BE95496.1000709@trash.net> (raw)
In-Reply-To: <1272880297-11198-12-git-send-email-jengelh@medozas.de>

Jan Engelhardt wrote:
> Each table implementation has a private built-in hardwired match
> function for its corresponding nfproto data (e.g. ip_tables: struct
> ipt6_ip6 processed by ip6_packet_match to match against the IPv6
> header, etc.)
> 
> Rewrite the functions so that they are independent xt_matches and can
> be used from an nfproto-independent table.

No major objections, but I'd like to know where this is going
and when, so far this doesn't provide any benefit.

And as always, please format things like

> +	ret = ifname_compare_aligned((par->in == NULL) ? nulldevname :
> +	      par->in->name, ipinfo->iniface, ipinfo->iniface_mask);

so the arguments are neatly aligned. F.i.

	ret = ifname_compare_aligned(!par->in ? nulldevname : par->in->name,
				     ipinfo->iniface, ipinfo->iniface_mask);

would work nicely.

  reply	other threads:[~2010-05-11 12:59 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-03  9:51 nf-next: a mixed bag Jan Engelhardt
2010-05-03  9:51 ` [PATCH 01/11] netfilter: ip_tables: fix compilation when debug is enabled Jan Engelhardt
2010-05-03  9:51 ` [PATCH 02/11] netfilter: xtables: fix incorrect return code Jan Engelhardt
2010-05-03  9:51 ` [PATCH 03/11] netfilter: xtables: dissolve do_match function Jan Engelhardt
2010-05-03  9:51 ` [PATCH 04/11] netfilter: xtables: combine struct xt_match_param and xt_target_param Jan Engelhardt
2010-05-03  9:51 ` [PATCH 05/11] netfilter: xtables: substitute temporary defines by final name Jan Engelhardt
2010-05-03  9:51 ` [PATCH 06/11] netfilter: xtables: deconstify struct xt_action_param for matches Jan Engelhardt
2010-05-03  9:51 ` [PATCH 07/11] netfilter: xtables: change hotdrop pointer to direct modification Jan Engelhardt
2010-05-03  9:51 ` [PATCH 08/11] netfilter: xtables: combine built-in extension structs Jan Engelhardt
2010-05-03  9:51 ` [PATCH 09/11] netfilter: ebtables: change ebt_basic_match to xt convention Jan Engelhardt
2010-05-03  9:51 ` [PATCH 10/11] netfilter: xtables: move functions around Jan Engelhardt
2010-05-03  9:51 ` [PATCH 11/11] netfilter: xtables: convert basic nfproto match functions into xt matches Jan Engelhardt
2010-05-11 12:59   ` Patrick McHardy [this message]
2010-05-11 13:38     ` Jan Engelhardt
2010-05-11 13:45       ` Patrick McHardy
2010-05-11 16:08         ` Jan Engelhardt
2010-05-07 20:11 ` nf-next: a mixed bag Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BE95496.1000709@trash.net \
    --to=kaber@trash.net \
    --cc=jengelh@medozas.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.