Re: [PATCH 4/7][RFC] qla4xxx: added Add host attributes to export host information to sysfs.

[Mike Christie <michaelc@cs.wisc.edu>]

On 05/11/2010 02:57 AM, Vikas Chaudhary wrote:
> +struct device_attribute *qla4xxx_host_attrs[] = {
> +	&dev_attr_driver_version,

Are we still supposed to be using the MODULE_VERSION() and 
/sys/module/qla4xxx/version for this? It seems like that was given as a 
review comment for a while, but some drivers have added it and some have 
not.



> +	&dev_attr_fw_version,
> +	&dev_attr_serial_num,
> +	&dev_attr_isp_name,
> +	&dev_attr_fw_state,
> +	&dev_attr_board_id,
> +	&dev_attr_hba_reset,


I think resetting the host should be a common scsi_host sysfs attr in 
scsi_sysfs.c. It seems other drivers have added their own reset host 
files, so I am fine with this if other people are.



> +	&dev_attr_ip_state,

I think this should be a common iscsi sysfs file. If we are going to do 
the userspace lib over that translates driver specifics to a common api 
though, then I am fine with this.