From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=43348 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OBsLX-0008MT-AU
	for qemu-devel@nongnu.org; Tue, 11 May 2010 12:30:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <jan.kiszka@siemens.com>) id 1OBsLR-0000rY-GI
	for qemu-devel@nongnu.org; Tue, 11 May 2010 12:30:15 -0400
Received: from david.siemens.de ([192.35.17.14]:15557)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <jan.kiszka@siemens.com>) id 1OBsLR-0000rG-6b
	for qemu-devel@nongnu.org; Tue, 11 May 2010 12:30:09 -0400
Message-ID: <4BE98600.5030905@siemens.com>
Date: Tue, 11 May 2010 18:29:52 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <1271782566-16420-1-git-send-email-agraf@suse.de>	<4BE024A9.2040904@codemonkey.ws>	<16E7906F-F39B-4121-B540-E2F0E67D405E@suse.de>	<4BE0307C.1010305@codemonkey.ws>	<0D8C0E80-5325-4E50-A2EF-E73BB95AD8DA@suse.de>	<4BE04A78.6070505@codemonkey.ws>
	<4BE05034.9060803@siemens.com> <4BE11F54.1030900@web.de>
	<4BE12763.8000809@web.de> <4BE18E60.8070709@siemens.com>
	<4BE98445.9000203@suse.de>
In-Reply-To: <4BE98445.9000203@suse.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Bastian Blank <waldi@debian.org>, Aurelien Jarno <aurelien@aurel32.net>, qemu-devel Developers <qemu-devel@nongnu.org>

Alexander Graf wrote:
> Jan Kiszka wrote:
>> Move the buffer flush from mux_chr_read to mux_chr_can_read. While the
>> latter is called periodically, the former will only be invoked when new
>> characters arrive at the back-end. This caused problems to front-end
>> drivers whenever they were unable to read data immediately, e.g.
>> virtio-console attached to stdio.
>>   
> 
> I don't see this patch applied, but also don't see any issues with
> virtio-console anymore on today's git. Odd.
> 

Hmm, I had a clear before-after experience using virtio console with an
x86 Linux guest. I still think my patch is correct and required. Maybe
you can bisect this positive "regression"? Something might paper over
the core issue now.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux