From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=49985 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OBsQK-0002K4-5T
	for qemu-devel@nongnu.org; Tue, 11 May 2010 12:35:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <agraf@suse.de>) id 1OBsQI-0001am-Ib
	for qemu-devel@nongnu.org; Tue, 11 May 2010 12:35:12 -0400
Received: from cantor2.suse.de ([195.135.220.15]:40984 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <agraf@suse.de>) id 1OBsQI-0001aX-DD
	for qemu-devel@nongnu.org; Tue, 11 May 2010 12:35:10 -0400
Message-ID: <4BE9873C.9050301@suse.de>
Date: Tue, 11 May 2010 18:35:08 +0200
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1271782566-16420-1-git-send-email-agraf@suse.de>	<4BE024A9.2040904@codemonkey.ws>	<16E7906F-F39B-4121-B540-E2F0E67D405E@suse.de>	<4BE0307C.1010305@codemonkey.ws>	<0D8C0E80-5325-4E50-A2EF-E73BB95AD8DA@suse.de>	<4BE04A78.6070505@codemonkey.ws>
	<4BE05034.9060803@siemens.com> <4BE11F54.1030900@web.de>
	<4BE12763.8000809@web.de> <4BE18E60.8070709@siemens.com>
	<4BE98445.9000203@suse.de> <4BE98600.5030905@siemens.com>
In-Reply-To: <4BE98600.5030905@siemens.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Bastian Blank <waldi@debian.org>, Aurelien Jarno <aurelien@aurel32.net>, qemu-devel Developers <qemu-devel@nongnu.org>

Jan Kiszka wrote:
> Alexander Graf wrote:
>   
>> Jan Kiszka wrote:
>>     
>>> Move the buffer flush from mux_chr_read to mux_chr_can_read. While the
>>> latter is called periodically, the former will only be invoked when new
>>> characters arrive at the back-end. This caused problems to front-end
>>> drivers whenever they were unable to read data immediately, e.g.
>>> virtio-console attached to stdio.
>>>   
>>>       
>> I don't see this patch applied, but also don't see any issues with
>> virtio-console anymore on today's git. Odd.
>>
>>     
>
> Hmm, I had a clear before-after experience using virtio console with an
> x86 Linux guest. I still think my patch is correct and required. Maybe
> you can bisect this positive "regression"? Something might paper over
> the core issue now.
>   

I just did a git reset --hard on
baf0b55a9e57b909b1f8b0f732c0b10242867418 and it worked! What the ...

Alex