From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from moutng.kundenserver.de ([212.227.126.171]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1OC2rz-00025W-Bh for kexec@lists.infradead.org; Wed, 12 May 2010 03:44:28 +0000 Date: Tue, 11 May 2010 20:44:24 -0700 (PDT) From: Christian Kujau Subject: Re: [PATCH 1/2] Fix kexec on powerpc32 In-Reply-To: <20100511174749.19309.44615.stgit@muvarov> Message-ID: <4BEA2375.7040802@nerdbynature.de> References: <20100511174749.19309.44615.stgit@muvarov> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Maxim Uvarov Cc: kexec@lists.infradead.org, uvarov@dev.rtsoft.ru, linuxppc-dev@lists.ozlabs.org TWF4aW0gVXZhcm92IHdyb3RlIG9uIDIwMTAtMDUtMTEgMTA6NDcgOgo+IFRoaXMgcGF0Y2ggaXMg cmVxdWlyZWQgaW4gY2FzZSBpZiB5b3UgYXJlIHVzaW5nIG5ldyB0b29sY2hhaW5zLgoKSSdtIG9u IERlYmlhbi9zdGFibGUgKGJpbnV0aWxzIDIuMTgsIGdjYyA0LjMuMiksIHNvIEkgYXBwbGllZCB5 b3VyIHBhdGNoZXMgCnRvIHRoZSBsYXRlc3QgLWdpdCBjaGVja291dDoKCkZpcnN0LCBjb21waWxh dGlvbiBmYWlscyB3aXRoOgoKY2MxOiB3YXJuaW5ncyBiZWluZyB0cmVhdGVkIGFzIGVycm9ycwpr ZXhlYy9hcmNoL3BwYy9rZXhlYy1wcGMuYzogSW4gZnVuY3Rpb24g4oCYZ2V0X2Jhc2VfcmFuZ2Vz 4oCZOgprZXhlYy9hcmNoL3BwYy9rZXhlYy1wcGMuYzoyNTg6IGVycm9yOiB2YWx1ZSBjb21wdXRl ZCBpcyBub3QgdXNlZAptYWtlOiAqKiogW2tleGVjL2FyY2gvcHBjL2tleGVjLXBwYy5vXSBFcnJv ciAxCgpTb21laG93IGEgIi0iIGh5cGhlbiBtYWRlIGl0IGludG8gb25lIG9mIHRoZSBmdW5jdGlv bnM6Cgo+IC0tLSBhL2tleGVjL2FyY2gvcHBjL2tleGVjLXBwYy5jCj4gKysrIGIva2V4ZWMvYXJj aC9wcGMva2V4ZWMtcHBjLmMKWy4uLl0KPiAgCQkJaWYgKGxvY2FsX21lbW9yeV9yYW5nZXMgPj0g bWF4X21lbW9yeV9yYW5nZXMpIHsKPiAtCQkJCWZjbG9zZShmaWxlKTsKPiAtCQkJCWJyZWFrOwo+ ICsJCQkJaWYgKHJlYWxsb2NfbWVtb3J5X3JhbmdlcygpIDwgMCl7Cj4gKwktCQkJCWZjbG9zZShm aWxlKTsKCgpSZW1vdmluZyB0aGlzLCBnZXRzIG1lIGZ1cnRoZXIsIHVudGlsOgoKCnB1cmdhdG9y eS9hcmNoL3BwYy9jcnQubzogSW4gZnVuY3Rpb24gYF9fbHNocmRpMyc6CigudGV4dCsweGYwKTog bXVsdGlwbGUgZGVmaW5pdGlvbiBvZiBgX19sc2hyZGkzJwpwdXJnYXRvcnkvYXJjaC9wcGMvbWlz Yy5vOigudGV4dCsweDUwKTogZmlyc3QgZGVmaW5lZCBoZXJlCmNvbGxlY3QyOiBsZCByZXR1cm5l ZCAxIGV4aXQgc3RhdHVzCm1ha2U6ICoqKiBbcHVyZ2F0b3J5L3B1cmdhdG9yeS5yb10gRXJyb3Ig MQoKQW5kIGhhcyBiZWVuIGRlZmluZWQgaW4gcHVyZ2F0b3J5L2FyY2gvcHBjL2NydC5TIGFuZAou L3B1cmdhdG9yeS9hcmNoL3BwYy9taXNjLlMuIFJlbW92aW5nIGl0IGZyb20gZS5nLiBjcnQuUwpt YWtlcyBpdCBjb21waWxlLCBJIGhhdmUgbm90IHRlc3RlZCBpdCB5ZXQsIHRob3VnaCA6LSkKClRo YW5rcywKQ2hyaXN0aWFuLgoKUFM6IFdoZXJlIGlzIC1XZXJyb3IgZGVmaW5lZD8gSSBjb3VsZCBu b3QgZmluZCBpdCBhbnl3aGVyZSBpbiB0aGUga2V4ZWMgCiAgICBzb3VyY2UgKGV4ZWNwdCBpbiBh cmNoL21pcHMpLi4uCi0tIAptYWtlIGJ6SW1hZ2UsIG5vdCB3YXIKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmtleGVjIG1haWxpbmcgbGlzdAprZXhlY0Bs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8va2V4ZWMK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.171]) by ozlabs.org (Postfix) with ESMTP id 500C3B7DD4 for ; Wed, 12 May 2010 13:44:31 +1000 (EST) Date: Tue, 11 May 2010 20:44:24 -0700 (PDT) From: Christian Kujau To: Maxim Uvarov Subject: Re: [PATCH 1/2] Fix kexec on powerpc32 In-Reply-To: <20100511174749.19309.44615.stgit@muvarov> Message-ID: <4BEA2375.7040802@nerdbynature.de> References: <20100511174749.19309.44615.stgit@muvarov> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=UTF-8 Cc: kexec@lists.infradead.org, uvarov@dev.rtsoft.ru, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Maxim Uvarov wrote on 2010-05-11 10:47 : > This patch is required in case if you are using new toolchains. I'm on Debian/stable (binutils 2.18, gcc 4.3.2), so I applied your patches= =20 to the latest -git checkout: First, compilation fails with: cc1: warnings being treated as errors kexec/arch/ppc/kexec-ppc.c: In function =E2=80=98get_base_ranges=E2=80=99: kexec/arch/ppc/kexec-ppc.c:258: error: value computed is not used make: *** [kexec/arch/ppc/kexec-ppc.o] Error 1 Somehow a "-" hyphen made it into one of the functions: > --- a/kexec/arch/ppc/kexec-ppc.c > +++ b/kexec/arch/ppc/kexec-ppc.c [...] > =09=09=09if (local_memory_ranges >=3D max_memory_ranges) { > -=09=09=09=09fclose(file); > -=09=09=09=09break; > +=09=09=09=09if (realloc_memory_ranges() < 0){ > +=09-=09=09=09=09fclose(file); Removing this, gets me further, until: purgatory/arch/ppc/crt.o: In function `__lshrdi3': (.text+0xf0): multiple definition of `__lshrdi3' purgatory/arch/ppc/misc.o:(.text+0x50): first defined here collect2: ld returned 1 exit status make: *** [purgatory/purgatory.ro] Error 1 And has been defined in purgatory/arch/ppc/crt.S and =2E/purgatory/arch/ppc/misc.S. Removing it from e.g. crt.S makes it compile, I have not tested it yet, though :-) Thanks, Christian. PS: Where is -Werror defined? I could not find it anywhere in the kexec=20 source (execpt in arch/mips)... --=20 make bzImage, not war