From: Avi Kivity <avi@redhat.com>
To: Mohammed Gamal <m.gamal005@gmail.com>
Cc: mtosatti@redhat.com, kvm@vger.kernel.org
Subject: Re: [PATCH 1/2] x86 emulator: Add missing decoder flags for sub instruction
Date: Wed, 12 May 2010 12:37:14 +0300 [thread overview]
Message-ID: <4BEA76CA.9020808@redhat.com> (raw)
In-Reply-To: <1273617562-6275-1-git-send-email-m.gamal005@gmail.com>
On 05/12/2010 01:39 AM, Mohammed Gamal wrote:
> This adds missing decoder flags for sub instructions (opcodes 0x2c - 0x2d)
>
>
Looks good (both patches). Please post test cases for realmode.c.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
next prev parent reply other threads:[~2010-05-12 9:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-11 22:39 [PATCH 1/2] x86 emulator: Add missing decoder flags for sub instruction Mohammed Gamal
2010-05-11 22:39 ` [PATCH 2/2] x86 emulator: Add missing decoder flags for xor instructions Mohammed Gamal
2010-05-12 9:37 ` Avi Kivity [this message]
2010-05-13 18:50 ` [PATCH 1/2] x86 emulator: Add missing decoder flags for sub instruction Marcelo Tosatti
2010-05-13 20:26 ` Mohammed Gamal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BEA76CA.9020808@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=m.gamal005@gmail.com \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.