Re: [PATCH] module-base.bbclass: keep PR if MACHINE_KERNEL_PR is not set

["Eric Bénard" <eric@eukrea.com>]

Le 03/05/2010 23:21, Eric Benard a écrit :
> Signed-off-by: Eric Benard<eric@eukrea.com>
> ---
>   classes/module-base.bbclass |    7 ++++++-
>   1 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/classes/module-base.bbclass b/classes/module-base.bbclass
> index bc53e1b..9aaaa4e 100644
> --- a/classes/module-base.bbclass
> +++ b/classes/module-base.bbclass
> @@ -7,7 +7,12 @@ export CROSS_COMPILE = "${TARGET_PREFIX}"
>
>   # A machine.conf or local.conf can increase MACHINE_KERNEL_PR to force
>   # rebuilds for kernel and external modules
> -PR = "${MACHINE_KERNEL_PR}"
> +python __anonymous () {
> +    machine_kernel_pr = bb.data.getVar('MACHINE_KERNEL_PR', d, True)
> +
> +    if machine_kernel_pr:
> +       bb.data.setVar('PR', machine_kernel_pr, d)
> +}
>
>   export KERNEL_VERSION = "${@base_read_file('${STAGING_KERNEL_DIR}/kernel-abiversion')}"
>   export KERNEL_SOURCE = "${@base_read_file('${STAGING_KERNEL_DIR}/kernel-source')}"

Actually, we loose PR if MACHINE_KERNEL_PR is not set.

Is this patch fine to solve this problem or is there another prefered way ?

Thanks,
Eric