From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Fitzhardinge Subject: Re: cpu_down() but no cpu_up() in drivers/xen/cpu_hotplug.c ? Date: Wed, 12 May 2010 09:26:40 -0700 Message-ID: <4BEAD6C0.9010902@goop.org> References: <4BE940C80200007800002410@vpn.id2.novell.com> <1273571127.7572.2905.camel@zakaz.uk.xensource.com> <4BE9967F.7080409@goop.org> <789F9655DD1B8F43B48D77C5D30659731E5F1EEC@shsmsx501.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <789F9655DD1B8F43B48D77C5D30659731E5F1EEC@shsmsx501.ccr.corp.intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Jiang, Yunhong" Cc: "xen-devel@lists.xensource.com" , Ian Campbell , Jan Beulich List-Id: xen-devel@lists.xenproject.org On 05/11/2010 08:25 PM, Jiang, Yunhong wrote: >> Yes, it was to make it consistent with native physical CPU hotplug. It >> also replaced some other xen-specific mechanism to allow the domain to >> control when the cpu was actually added (I forget the details; something >> like "cpus allowed" vs "cpus active" or something?). >> > I remember for cpu remove, the xen's vcpu is different to native method. In native, it will only trigger a uevent to user space (at least in version like 2.6.31), while for xen vcpu, it will remove the vcpu directly. > I would think that Xen and native are much the same; if you pull out a physical CPU from the system, that's in no way advisory ;) Similarly, if you remove a vcpu from a guest, that's an external policy being imposed onto the guest, and it doesn't get much say in the matter, beyond being able to clean up before the vcpu goes away. If the domain wants to stop using a vcpu, it can simply do that by soft-downing the vcpu, but it remains attached to the domain (again, analogous to the native case). J