All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Weil <weil@mail.berlios.de>
Cc: "François Revol" <revol@free.fr>, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] block/vdi: Fix image opening and creation for odd disk sizes
Date: Wed, 12 May 2010 20:56:11 +0200	[thread overview]
Message-ID: <4BEAF9CB.1080909@redhat.com> (raw)
In-Reply-To: <1273688745-8828-1-git-send-email-weil@mail.berlios.de>

Am 12.05.2010 20:25, schrieb Stefan Weil:
> The fix is based on a patch from Kevin Wolf. Here his comment:
> 
> "The number of blocks needs to be rounded up to cover all of the virtual hard
> disk. Without this fix, we can't even open our own images if their size is not
> a multiple of the block size."
> 
> While Kevin's patch addressed vdi_create, my modification also fixes
> vdi_open which now accepts images with odd disk sizes.
> 
> v3:
> Don't allow reading of disk images with too large disk sizes.
> Neither VBoxManage nor old versions of qemu-img read such images.
> This change requires rounding of odd disk sizes before we do the checks.
> 
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: François Revol <revol@free.fr>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>

Thanks, applied to the block branch.

Kevin

      reply	other threads:[~2010-05-12 18:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-06 12:55 [Qemu-devel] [PATCH] vdi: Fix image creation Kevin Wolf
2010-05-06 18:05 ` [Qemu-devel] " Stefan Weil
2010-05-06 18:29   ` [Qemu-devel] [PATCH] vdi: Fix image opening and creation for odd disk sizes Stefan Weil
2010-05-07  7:55     ` [Qemu-devel] " Kevin Wolf
2010-05-07 11:55       ` François Revol
2010-05-09 10:17         ` Stefan Weil
2010-05-10  7:47           ` Kevin Wolf
2010-05-10 20:12             ` [Qemu-devel] " Stefan Weil
2010-05-10 20:44               ` [Qemu-devel] " François Revol
2010-05-11  7:52               ` Kevin Wolf
2010-05-12 18:25                 ` [Qemu-devel] [PATCH] block/vdi: " Stefan Weil
2010-05-12 18:56                   ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BEAF9CB.1080909@redhat.com \
    --to=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=revol@free.fr \
    --cc=weil@mail.berlios.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.