From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=36939 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OCPEw-0003XR-NF for qemu-devel@nongnu.org; Wed, 12 May 2010 23:37:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OCJxY-0005wP-EX for qemu-devel@nongnu.org; Wed, 12 May 2010 17:59:22 -0400 Received: from fmmailgate01.web.de ([217.72.192.221]:39614) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OCJxY-0005vt-46 for qemu-devel@nongnu.org; Wed, 12 May 2010 17:59:20 -0400 Message-ID: <4BEB068A.6090800@web.de> Date: Wed, 12 May 2010 21:50:34 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1273692285-9802-1-git-send-email-weil@mail.berlios.de> In-Reply-To: <1273692285-9802-1-git-send-email-weil@mail.berlios.de> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig0F326C85E4FDF8B50C2E9282" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH] target-i386: Avoid kvm related compiler error List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig0F326C85E4FDF8B50C2E9282 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Stefan Weil wrote: > Some versions of kvm.h (debian lenny) define KVM_CAP_VCPU_EVENTS > without defining KVM_VCPUEVENT_VALID_NMI_PENDING or > KVM_VCPUEVENT_VALID_SIPI_VECTOR. This rather looks like a bug to be sent to debian. Until they fixed their backport (I just hope it's a user space header issue only...), you could disable KVM or use kvm-kmod which delivers proper upstream headers.= Jan >=20 > Without the patch, compilation fails: >=20 > CC x86_64-softmmu/kvm.o > /qemu/target-i386/kvm.c: In function 'kvm_put_vcpu_events': > /qemu/target-i386/kvm.c:824: error: 'KVM_VCPUEVENT_VALID_NMI_PENDING' u= ndeclared (first use in this function) > /qemu/target-i386/kvm.c:824: error: (Each undeclared identifier is repo= rted only once > /qemu/target-i386/kvm.c:824: error: for each function it appears in.) > /qemu/target-i386/kvm.c:824: error: 'KVM_VCPUEVENT_VALID_SIPI_VECTOR' u= ndeclared (first use in this function) > make[1]: *** [kvm.o] Error 1 >=20 > Cc: Jan Kiszka > Signed-off-by: Stefan Weil > --- > target-i386/kvm.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) >=20 > diff --git a/target-i386/kvm.c b/target-i386/kvm.c > index f73b47b..9a37753 100644 > --- a/target-i386/kvm.c > +++ b/target-i386/kvm.c > @@ -796,7 +796,7 @@ static int kvm_get_mp_state(CPUState *env) > =20 > static int kvm_put_vcpu_events(CPUState *env, int level) > { > -#ifdef KVM_CAP_VCPU_EVENTS > +#if defined(KVM_CAP_VCPU_EVENTS) && defined(KVM_VCPUEVENT_VALID_NMI_PE= NDING) > struct kvm_vcpu_events events; > =20 > if (!kvm_has_vcpu_events()) { --------------enig0F326C85E4FDF8B50C2E9282 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkvrBpAACgkQitSsb3rl5xQxhgCfaKcsutG9O4RMTuf5/ymfjqk3 1zMAoLv1X2fsyBhHJtWo3q+fJ5g8tbpc =wmyP -----END PGP SIGNATURE----- --------------enig0F326C85E4FDF8B50C2E9282--