From mboxrd@z Thu Jan 1 00:00:00 1970 From: MORITA Kazutaka Subject: Re: [Qemu-devel] [RFC PATCH 1/2] close all the block drivers before the qemu process exits Date: Thu, 13 May 2010 04:50:50 +0900 Message-ID: <4BEB069A.8060707@lab.ntt.co.jp> References: <1273661213-19611-1-git-send-email-morita.kazutaka@lab.ntt.co.jp> <1273661213-19611-2-git-send-email-morita.kazutaka@lab.ntt.co.jp> <20100512140132.GA11876@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org, sheepdog-CJ+3F33aHDCwRfvgX43A7Q@public.gmane.org, kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org, avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org To: Christoph Hellwig Return-path: In-Reply-To: <20100512140132.GA11876-jcswGhMUV9g@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: sheepdog-bounces-CJ+3F33aHDCwRfvgX43A7Q@public.gmane.org Errors-To: sheepdog-bounces-CJ+3F33aHDCwRfvgX43A7Q@public.gmane.org List-Id: kvm.vger.kernel.org On 2010/05/12 23:01, Christoph Hellwig wrote: > On Wed, May 12, 2010 at 07:46:52PM +0900, MORITA Kazutaka wrote: >> This patch calls the close handler of the block driver before the qemu >> process exits. >> >> This is necessary because the sheepdog block driver releases the lock >> of VM images in the close handler. >> >> Signed-off-by: MORITA Kazutaka > > Looks good in principle, except that bdrv_first is gone and has been > replaced with a real list in the meantime, so this won't even apply. > Thank you for your comment. I'll rebase and resend the updated version in the next days. Thanks, Kazutaka From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=54183 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OCPGg-0006Kv-LC for qemu-devel@nongnu.org; Wed, 12 May 2010 23:39:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OCJT2-0001AT-A8 for qemu-devel@nongnu.org; Wed, 12 May 2010 17:28:06 -0400 Received: from tama500.ecl.ntt.co.jp ([129.60.39.148]:55030) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OCJSz-00016Q-0c for qemu-devel@nongnu.org; Wed, 12 May 2010 17:27:47 -0400 Message-ID: <4BEB069A.8060707@lab.ntt.co.jp> Date: Thu, 13 May 2010 04:50:50 +0900 From: MORITA Kazutaka MIME-Version: 1.0 Subject: Re: [Qemu-devel] [RFC PATCH 1/2] close all the block drivers before the qemu process exits References: <1273661213-19611-1-git-send-email-morita.kazutaka@lab.ntt.co.jp> <1273661213-19611-2-git-send-email-morita.kazutaka@lab.ntt.co.jp> <20100512140132.GA11876@lst.de> In-Reply-To: <20100512140132.GA11876@lst.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: aliguori@us.ibm.com, sheepdog@lists.wpkg.org, kvm@vger.kernel.org, qemu-devel@nongnu.org, fujita.tomonori@lab.ntt.co.jp, avi@redhat.com On 2010/05/12 23:01, Christoph Hellwig wrote: > On Wed, May 12, 2010 at 07:46:52PM +0900, MORITA Kazutaka wrote: >> This patch calls the close handler of the block driver before the qemu >> process exits. >> >> This is necessary because the sheepdog block driver releases the lock >> of VM images in the close handler. >> >> Signed-off-by: MORITA Kazutaka > > Looks good in principle, except that bdrv_first is gone and has been > replaced with a real list in the meantime, so this won't even apply. > Thank you for your comment. I'll rebase and resend the updated version in the next days. Thanks, Kazutaka