From mboxrd@z Thu Jan 1 00:00:00 1970 From: MORITA Kazutaka Subject: Re: [RFC PATCH 1/2] close all the block drivers before the qemu process exits Date: Thu, 13 May 2010 05:16:35 +0900 Message-ID: <4BEB0CA3.50209@lab.ntt.co.jp> References: <1273661213-19611-1-git-send-email-morita.kazutaka@lab.ntt.co.jp> <1273661213-19611-2-git-send-email-morita.kazutaka@lab.ntt.co.jp> <4BEABB0F.9030907@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org, sheepdog-CJ+3F33aHDCwRfvgX43A7Q@public.gmane.org, qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org, kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Avi Kivity Return-path: In-Reply-To: <4BEABB0F.9030907-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: sheepdog-bounces-CJ+3F33aHDCwRfvgX43A7Q@public.gmane.org Errors-To: sheepdog-bounces-CJ+3F33aHDCwRfvgX43A7Q@public.gmane.org List-Id: kvm.vger.kernel.org On 2010/05/12 23:28, Avi Kivity wrote: > On 05/12/2010 01:46 PM, MORITA Kazutaka wrote: >> This patch calls the close handler of the block driver before the qemu >> process exits. >> >> This is necessary because the sheepdog block driver releases the lock >> of VM images in the close handler. >> >> > > How do you handle abnormal termination? > In the case, we need to release the lock manually, unfortunately. Sheepdog admin tool has a command to do that. Thanks, Kazutaka From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=48561 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OCPGk-0002tv-Fg for qemu-devel@nongnu.org; Wed, 12 May 2010 23:39:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OCJSy-000192-F3 for qemu-devel@nongnu.org; Wed, 12 May 2010 17:27:51 -0400 Received: from tama500.ecl.ntt.co.jp ([129.60.39.148]:55030) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OCJSv-00016Q-Mo for qemu-devel@nongnu.org; Wed, 12 May 2010 17:27:42 -0400 Message-ID: <4BEB0CA3.50209@lab.ntt.co.jp> Date: Thu, 13 May 2010 05:16:35 +0900 From: MORITA Kazutaka MIME-Version: 1.0 References: <1273661213-19611-1-git-send-email-morita.kazutaka@lab.ntt.co.jp> <1273661213-19611-2-git-send-email-morita.kazutaka@lab.ntt.co.jp> <4BEABB0F.9030907@redhat.com> In-Reply-To: <4BEABB0F.9030907@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [RFC PATCH 1/2] close all the block drivers before the qemu process exits List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: fujita.tomonori@lab.ntt.co.jp, aliguori@us.ibm.com, sheepdog@lists.wpkg.org, qemu-devel@nongnu.org, kvm@vger.kernel.org On 2010/05/12 23:28, Avi Kivity wrote: > On 05/12/2010 01:46 PM, MORITA Kazutaka wrote: >> This patch calls the close handler of the block driver before the qemu >> process exits. >> >> This is necessary because the sheepdog block driver releases the lock >> of VM images in the close handler. >> >> > > How do you handle abnormal termination? > In the case, we need to release the lock manually, unfortunately. Sheepdog admin tool has a command to do that. Thanks, Kazutaka