All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boaz Harrosh <bharrosh@panasas.com>
To: Benny Halevy <bhalevy@panasas.com>, NFS list <linux-nfs@vger.kernel.org>
Subject: SQUASHME: missing from FIXME: async layout return
Date: Thu, 13 May 2010 11:40:09 +0300	[thread overview]
Message-ID: <4BEBBAE9.8090605@panasas.com> (raw)

I've tested the patch:
	FIXME: async layout return

And there is a missing small hunk

I have tested with this patch and it is a very good patch
that should also go into 2.6.33. It is necessary in the rare
case when one inode have more then one open_context.

(For some reason I see that happening much more in 2.6.34
 I don't understand why)

Boaz
---
git diff --stat -p -M
 fs/nfs/nfs4state.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c
index 15c8bc8..6dbe893 100644
--- a/fs/nfs/nfs4state.c
+++ b/fs/nfs/nfs4state.c
@@ -590,7 +590,7 @@ static void __nfs4_close(struct path *path, struct nfs4_state *state, fmode_t fm
 		struct nfs_inode *nfsi = NFS_I(state->inode);
 
 		if (nfsi->layoutcommit_ctx)
-			pnfs_layoutcommit_inode(state->inode, 0);
+			pnfs_layoutcommit_inode(state->inode, wait);
 		if (has_layout(nfsi) && nfsi->layout.roc_iomode) {
 			struct nfs4_pnfs_layout_segment range;
 

             reply	other threads:[~2010-05-13  8:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-13  8:40 Boaz Harrosh [this message]
2010-05-13 14:07 ` SQUASHME: missing from FIXME: async layout return William A. (Andy) Adamson
     [not found]   ` <AANLkTilE4ao7UadJD58EzbExdfwE4zU5DF-6Nit29Yjq-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-05-13 14:39     ` Benny Halevy
2010-05-13 14:19 ` William A. (Andy) Adamson
     [not found]   ` <AANLkTind3eXmuPw5HrKqB6bHJSSXFL3g2cDSEyyYc1n8-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-05-13 14:40     ` Benny Halevy
2010-05-13 15:17       ` William A. (Andy) Adamson
     [not found]         ` <AANLkTilhbkde-kAPGSBHT1b8vIZq4cM1SPpI-Rd0iOb7-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-05-13 15:31           ` Boaz Harrosh
2010-05-13 16:04             ` William A. (Andy) Adamson
2010-05-13 16:20               ` Benny Halevy
2010-05-14  3:28                 ` Zhang Jingwang
2010-05-17  6:02                   ` Benny Halevy
2010-05-13 16:23               ` Boaz Harrosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BEBBAE9.8090605@panasas.com \
    --to=bharrosh@panasas.com \
    --cc=bhalevy@panasas.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.