From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vincent Hanquez <vincent.hanquez@eu.citrix.com>
Subject: Re: [PATCH 1/2]xl: Add "xl uptime" command
Date: Thu, 13 May 2010 10:54:41 +0100
Message-ID: <4BEBCC61.3000703@eu.citrix.com>
References: <4BEBC81A.70109@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4BEBC81A.70109@cn.fujitsu.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Yang Hongyang <yanghy@cn.fujitsu.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 13/05/10 10:36, Yang Hongyang wrote:
> Add "xl uptime" command, a clone of "xm uptime".
>
> Signed-off-by: Yang Hongyang<yanghy@cn.fujitsu.com>
>
> diff -r d77a88f938c6 tools/libxl/libxl.c
> --- a/tools/libxl/libxl.c	Tue May 11 14:05:28 2010 +0100
> +++ b/tools/libxl/libxl.c	Fri May 14 01:25:56 2010 +0800
> @@ -2629,3 +2629,23 @@
>
>       return rc;
>   }
> +
> +unsigned long libxl_get_start_time(struct libxl_ctx *ctx, uint32_t domid)
> +{
> +    char *dompath = libxl_xs_get_dompath(ctx, domid);
> +    unsigned long s_time = 0;
> +    char *start_time = NULL;
> +    char *vm_path = NULL;
> +
> +    vm_path = libxl_xs_read(ctx, XBT_NULL, libxl_sprintf(ctx, "%s/vm", dompath));
> +    start_time = libxl_xs_read(ctx, XBT_NULL, libxl_sprintf(ctx, "%s/start_time", vm_path));
> +    if (start_time == NULL) {
> +        XL_LOG_ERRNOVAL(ctx, XL_LOG_ERROR, -1,
> +            "Can't get start time of domain '%d'", domid);
> +        return -1;
> +    }
> +    s_time = strtoul(start_time, NULL, 10);
> +
> +    return s_time;
> +}

this function should more than likely return a uint64_t or a uint32_t, 
but certainly not an unsigned long. and since it apply to a domain it 
should be call libxl_domain_get_start_time.

I find this command basically useless, since on restore the "start_time" 
is not kept. do we actually need this ?

-- 
Vincent