From: Richard Henderson <rth@twiddle.net>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] linux-user: use default mmap_min_addr 65536 when /proc/sys/vm/mmap_min_addr cannot be read
Date: Thu, 13 May 2010 09:59:24 -0700 [thread overview]
Message-ID: <4BEC2FEC.6070900@twiddle.net> (raw)
In-Reply-To: <1273756645-11149-1-git-send-email-Martin.Jansa@gmail.com>
On 05/13/2010 06:17 AM, Martin Jansa wrote:
> @@ -2899,8 +2900,14 @@ int main(int argc, char **argv, char **envp)
> if (fscanf(fp, "%lu", &tmp) == 1) {
> mmap_min_addr = tmp;
> qemu_log("host mmap_min_addr=0x%lx\n", mmap_min_addr);
> + } else {
> + qemu_log("cannot read value from /proc/sys/vm/mmap_min_addr, assuming %d\n", MMAP_MIN_ADDR_DEFAULT);
> + mmap_min_addr = MMAP_MIN_ADDR_DEFAULT;
> }
> fclose(fp);
> + } else {
> + qemu_log("cannot open /proc/sys/vm/mmap_min_addr for reading, assuming %d\n", MMAP_MIN_ADDR_DEFAULT);
> + mmap_min_addr = MMAP_MIN_ADDR_DEFAULT;
> }
> }
Perhaps you can combine these two else clauses?
r~
next prev parent reply other threads:[~2010-05-13 16:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-13 13:17 [Qemu-devel] [PATCH] linux-user: use default mmap_min_addr 65536 when /proc/sys/vm/mmap_min_addr cannot be read Martin Jansa
2010-05-13 16:59 ` Richard Henderson [this message]
2010-05-13 19:26 ` Martin Jansa
2010-05-14 13:11 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BEC2FEC.6070900@twiddle.net \
--to=rth@twiddle.net \
--cc=martin.jansa@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.