From: David Daney <ddaney@caviumnetworks.com>
To: "Dezhong Diao (dediao)" <dediao@cisco.com>
Cc: linux-mips@linux-mips.org,
"David VomLehn (dvomlehn)" <dvomlehn@cisco.com>,
"Tony Colclough (colclot)" <colclot@cisco.com>,
Grant Likely <grant.likely@secretlab.ca>
Subject: Re: [RFC PATCH 1/2] The Device Tree Patch for MIPS
Date: Thu, 13 May 2010 13:24:10 -0700 [thread overview]
Message-ID: <4BEC5FEA.70101@caviumnetworks.com> (raw)
In-Reply-To: <7A9214B0DEB2074FBCA688B30B04400DC64936@XMB-RCD-208.cisco.com>
On 05/13/2010 11:50 AM, Dezhong Diao (dediao) wrote:
>>> +/* which is compatible with the flattened device tree (FDT) */
>>> +#define cmd_line arcs_cmdline
>
>> What is this #define floating in space?
>
> The variable "cmd_line" is being used in generic code of device tree,
> most of platforms (ARM, POWERPC
> , etc) have its definition, but it isn't present in MIPS. Actually there
> is a variable "arcs_cmdline" to be used as the same purpose in MIPS,
> that is the reason "arcs_cmdline" is given a new name.
>
Really I was referring to the way the patch got horked up when you
e-mailed it. It was very difficult to understand what the intent was.
I have no problem using #define, just make sure it doesn't have other
garbage preceding the '#'
prev parent reply other threads:[~2010-05-13 20:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-10 21:34 [RFC PATCH 1/2] The Device Tree Patch for MIPS Dezhong Diao (dediao)
2010-05-10 21:34 ` Dezhong Diao (dediao)
2010-05-12 17:24 ` David Daney
2010-05-13 18:50 ` Dezhong Diao (dediao)
2010-05-13 18:50 ` Dezhong Diao (dediao)
2010-05-13 20:24 ` David Daney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BEC5FEA.70101@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=colclot@cisco.com \
--cc=dediao@cisco.com \
--cc=dvomlehn@cisco.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.