All of lore.kernel.org
 help / color / mirror / Atom feed
From: viresh.kumar@st.com (Viresh KUMAR)
To: linux-arm-kernel@lists.infradead.org
Subject: Should we pass amba device peripheral id with device structure or not?
Date: Fri, 14 May 2010 12:32:18 +0530	[thread overview]
Message-ID: <4BECF57A.4050802@st.com> (raw)

Hello,

amba_device_register function reads and updates peripheral id from hardware
registers, whenever we register any amba device. If clock to device is disabled,
then amba_device_register will not be able to read and update this value.

Thus device registration will fail. Now we can also pass peripheral
id with the device structure, which will let it pass.
But i remember in SPEAr patches review, i got this comment to remove
peripheral id from device structure as it will be populated
automatically.

This is happening in our platform as we don't have separate control of
enabling/disabling interface and functional clocks of peripherals.

What should we do now? Enabling clocks from uboot doesn't looks a good idea.
Should we pass peripheral id with device structure only?

regards,
viresh kumar.

             reply	other threads:[~2010-05-14  7:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-14  7:02 Viresh KUMAR [this message]
2010-05-14 14:25 ` Should we pass amba device peripheral id with device structure or not? Catalin Marinas
2010-05-21 19:38 ` Russell King - ARM Linux
2010-05-24  4:38   ` Viresh KUMAR
2010-05-24 21:32     ` Russell King - ARM Linux
2010-05-24 22:17       ` Linus Walleij
2010-05-24 22:32         ` Russell King - ARM Linux
2010-05-26  8:27       ` Viresh KUMAR
2010-05-24 21:51     ` Linus Walleij
2010-05-24 20:14 ` Linus Walleij
2010-05-26  8:30   ` Viresh KUMAR

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BECF57A.4050802@st.com \
    --to=viresh.kumar@st.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.