Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

[Kevin Wolf <kwolf@redhat.com>]

Am 12.05.2010 23:17, schrieb Luiz Capitulino:
> On Wed, 12 May 2010 18:48:38 +0200
> Markus Armbruster <armbru@redhat.com> wrote:
> 
>>> +query-block
>>> +-----------
>>> +
>>> +Show the block devices.
>>> +
>>> +Each block device information is stored in a json-object and the returned value
>>> +is a json-array of all devices.
>>> +
>>> +Each json-object contain the following:
>>> +
>>> +- "device": device name (json-string)
>>> +- "type": device type (json-string)
>>
>> Possible values?  "hd", "cdrom", "floppy".  Code also has "unknown", but
>> when it uses that, it's badly broken.
> 
>  Yes, but you didn't mean we shouldn't use 'unknown', right?
> 
>>> +- "removable": true if the device is removable, false otherwise (json-bool)
>>> +- "locked": true if the device is locked, false otherwise (json-bool)
>>> +- "inserted": only present if the device is inserted, it is a json-object
>>> +   containing the following:
>>> +         - "file": device file name (json-string)
>>> +         - "ro": true if read-only, false otherwise (json-bool)
>>> +         - "drv": driver format name (json-string)
>>
>> Possible values?
> 
>  I got the following list by grepping the code. Kevin, can you confirm it's
> correct?
> 
>  "blkdebug", "bochs", "cloop", "cow", "dmg", "file", "file", "ftp", "ftps",
>  "host_cdrom", "host_cdrom", "host_device", "host_device", "host_floppy",
>  "http", "https", "nbd", "parallels", "qcow", "qcow2", "raw", "tftp", "vdi",
>  "vmdk", "vpc", "vvfat"

Looks right. But you probably don't want to mention those drivers twice
that are present in both raw-posix.c and raw-win32.c.

Kevin