[Qemu-devel] Re: [PATCH 1/1] Add -version-simple argument, printing only version number.

[Anthony Liguori <aliguori@linux.vnet.ibm.com>]

On 05/13/2010 03:32 AM, Jes.Sorensen@redhat.com wrote:
> From: Jes Sorensen<Jes.Sorensen@redhat.com>
>
> Add -version-simple argument for QEMU, printing just the version
> number, without any supporting text.
>    

I'm not a huge fan of the name.

But what information are we trying to convey?  Just major/minor number 
or would qemu-kvm also throw some info in there?

Do version numbers even matter because 0.13 from qemu.git is going to be 
a hell of a lot different from 0.13 in RHEL6.x.

What are the consumers of this information actually doing with it?

Regards,

Anthony Liguori

> This makes it simpler for other apps, such as libvirt, to parse the
> version string from QEMU independant of how the naming string may
> change.
>
> Signed-off-by: Jes Sorensen<Jes.Sorensen@redhat.com>
> ---
>   qemu-options.hx |    8 ++++++++
>   vl.c            |    9 +++++++++
>   2 files changed, 17 insertions(+), 0 deletions(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 12f6b51..e4f3979 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -27,6 +27,14 @@ STEXI
>   Display version information and exit
>   ETEXI
>
> +DEF("version-simple", 0, QEMU_OPTION_version_simple,
> +    "-version-simple display version information and exit\n", QEMU_ARCH_ALL)
> +STEXI
> +@item -version-simple
> +@findex -version-simple
> +Display basic version number information and exit
> +ETEXI
> +
>   DEF("M", HAS_ARG, QEMU_OPTION_M,
>       "-M machine      select emulated machine (-M ? for list)\n", QEMU_ARCH_ALL)
>   STEXI
> diff --git a/vl.c b/vl.c
> index 85bcc84..5adca87 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2015,6 +2015,11 @@ static void version(void)
>       printf("QEMU emulator version " QEMU_VERSION QEMU_PKGVERSION ", Copyright (c) 2003-2008 Fabrice Bellard\n");
>   }
>
> +static void version_simple(void)
> +{
> +    printf(QEMU_VERSION QEMU_PKGVERSION "\n");
> +}
> +
>   static void help(int exitcode)
>   {
>       const char *options_help =
> @@ -2960,6 +2965,10 @@ int main(int argc, char **argv, char **envp)
>                   version();
>                   exit(0);
>                   break;
> +            case QEMU_OPTION_version_simple:
> +                version_simple();
> +                exit(0);
> +                break;
>               case QEMU_OPTION_m: {
>                   uint64_t value;
>                   char *ptr;
>