All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/2] libata: don't flush dcache on slab pages
Date: Fri, 14 May 2010 17:50:39 -0400	[thread overview]
Message-ID: <4BEDC5AF.7010605@pobox.com> (raw)
In-Reply-To: <20100321215222.GA27709@Chamillionaire.breakpoint.cc>

On 03/21/2010 05:52 PM, Sebastian Andrzej Siewior wrote:
> page_mapping() check this via VM_BUG_ON(PageSlab(page)) so we bug here
> with the according debuging turned on.
>
> Signed-off-by: Sebastian Andrzej Siewior<sebastian@breakpoint.cc>
> ---
>   drivers/ata/libata-sff.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c
> index 561dec2..83ecf48 100644
> --- a/drivers/ata/libata-sff.c
> +++ b/drivers/ata/libata-sff.c
> @@ -893,7 +893,7 @@ static void ata_pio_sector(struct ata_queued_cmd *qc)
>   				       do_write);
>   	}
>
> -	if (!do_write)
> +	if (!do_write&&  !PageSlab(page))
>   		flush_dcache_page(page);

applied #upstream, cc'ing stable@kernel.org



      parent reply	other threads:[~2010-05-14 21:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-21 21:52 [PATCH 1/2] libata: don't flush dcache on slab pages Sebastian Andrzej Siewior
2010-04-19 19:46 ` Sebastian Andrzej Siewior
2010-04-19 19:55   ` David Miller
2010-04-28 20:06 ` Sebastian Andrzej Siewior
2010-04-29  0:16   ` Jeff Garzik
2010-05-14 21:50 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BEDC5AF.7010605@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=sebastian@breakpoint.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.