From: Jan Kiszka <jan.kiszka@web.de>
To: andrzej zaborowski <balrogg@gmail.com>
Cc: Blue Swirl <blauwirbel@gmail.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>
Subject: [Qemu-devel] Re: [PATCH v2 1/6] tmp105: Drop unused faults field
Date: Sat, 15 May 2010 15:22:14 +0200 [thread overview]
Message-ID: <4BEEA006.1030308@web.de> (raw)
In-Reply-To: <AANLkTimzP6nK5qpkxkEJSKo-i0p8f674C_3uYUuE3dBn@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 921 bytes --]
andrzej zaborowski wrote:
> Hi Jan,
>
> On 15 May 2010 13:32, Jan Kiszka <jan.kiszka@web.de> wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> It was only written, but never read.
>
> I pushed an alternate version to just move the update from post_save
> to post_load. If you think of code as documentation, the struct
> becomes less complete in representing the state of the device if you
> remove the register. State doesn't have to be readable through the
> busses, some state may be readable through qemu monitor and the like.
That particular state is unreadable via any existing interface (except a
debugger). For pretty-printing TMP105State::config, there will once be
better mechanisms based on vmstate.
I don't mind if that dead code remains, I just want to underline that
it's useless (code as documentation was important before versioning
control entered the scene).
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]
next prev parent reply other threads:[~2010-05-15 13:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-15 11:32 [Qemu-devel] [PATCH v2 0/6] vmstate: Drop post_save / allow instance ID aliases Jan Kiszka
2010-05-15 11:32 ` [Qemu-devel] [PATCH v2 1/6] tmp105: Drop unused faults field Jan Kiszka
2010-05-15 12:33 ` [Qemu-devel] " andrzej zaborowski
2010-05-15 13:22 ` Jan Kiszka [this message]
2010-05-15 11:32 ` [Qemu-devel] [PATCH v2 2/6] vmstate: Drop unused post_save handler Jan Kiszka
2010-05-15 11:32 ` [Qemu-devel] [PATCH v2 3/6] vmstate: Add support for alias ID Jan Kiszka
2010-05-15 11:32 ` [Qemu-devel] [PATCH v2 4/6] serial: Register vmstate via qdev Jan Kiszka
2010-05-15 11:32 ` [Qemu-devel] [PATCH v2 5/6] fdc: " Jan Kiszka
2010-05-15 11:32 ` [Qemu-devel] [PATCH v2 6/6] mc146818rtc: " Jan Kiszka
2010-05-15 15:24 ` [Qemu-devel] Re: [PATCH v2 0/6] vmstate: Drop post_save / allow instance ID aliases Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BEEA006.1030308@web.de \
--to=jan.kiszka@web.de \
--cc=balrogg@gmail.com \
--cc=blauwirbel@gmail.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.