Re: [PATCH CLEANUP] sctp: fix the comment of sctp_sf_violation_paramlen()

[Shan Wei <shanwei@cn.fujitsu.com>]

Wei Yongjun wrote, at 05/17/2010 02:14 PM:
> 
> 于 2010年05月17日 14:08, Shan Wei 写道:
>> The comment about sctp_sf_violation_paramlen() is wrong.
>>
>> Invalid length should be identified as it does not equal actual length
>> of a given parameter. The actual length of a given parameter is not including
>> the padding part.
>>   
> 
> Not right. If the param length is larger then what is request, we
> also treat it as correct. And for unkonw params, we just check
> the length larger then the minimal length.

From the code of sctp_verify_asconf(), I saw that if length value of any parameter in chunk
is not equal true length, sctp_verify_asconf() return 0.

@@sctp_verify_asconf()
3045                 if (param.v > chunk_end - length ||
3046                     length < sizeof(sctp_paramhdr_t))
3047                         return 0;


-- 
Best Regards
-----
Shan Wei