From: Avi Kivity <avi@redhat.com>
To: Sheng Yang <sheng@linux.intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
kvm@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 3/3] KVM: x86: Use FPU API
Date: Mon, 17 May 2010 11:18:22 +0300 [thread overview]
Message-ID: <4BF0FBCE.5010002@redhat.com> (raw)
In-Reply-To: <1274083741-25856-1-git-send-email-sheng@linux.intel.com>
On 05/17/2010 11:09 AM, Sheng Yang wrote:
> Convert KVM to use generic FPU API.
>
> Signed-off-by: Sheng Yang<sheng@linux.intel.com>
> ---
> Like this? (Drop patch 1)
>
>
Will be more readable with a patch that converts host_fx_image to
unlazy_fpu(), and a second patch that converts guest_fx_image to the fpu
API.
I think unlazy_fpu() is even a performance win in case userspace doesn't
do a lot of floating point (which is the case with qemu). I wonder why
we didn't think of it before.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
next prev parent reply other threads:[~2010-05-17 8:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-14 3:16 [PATCH 0/3] Convert KVM to use FPU API Sheng Yang
2010-05-14 3:16 ` [PATCH 1/3] x86: Split fpu_save_init() to fpu_save() and fpu_clear() Sheng Yang
2010-05-14 3:16 ` [PATCH 2/3] x86: Export FPU API for KVM use Sheng Yang
2010-05-14 3:16 ` [PATCH 3/3] KVM: x86: Use FPU API Sheng Yang
2010-05-15 8:06 ` Avi Kivity
2010-05-17 8:09 ` Sheng Yang
2010-05-17 8:18 ` Avi Kivity [this message]
2010-05-17 8:22 ` Sheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BF0FBCE.5010002@redhat.com \
--to=avi@redhat.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mtosatti@redhat.com \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.