From: Kevin Wolf <kwolf@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] block: fix aio_flush segfaults for read-only protocols (e.g. curl)
Date: Mon, 17 May 2010 11:10:03 +0200 [thread overview]
Message-ID: <4BF107EB.7040709@redhat.com> (raw)
In-Reply-To: <1274011197-26196-1-git-send-email-avi@redhat.com>
Am 16.05.2010 13:59, schrieb Avi Kivity:
> Not all block format drivers expose an io_flush method (reasonable for
> read-only protocols), so calling io_flush there will immediately segfault.
>
> Fix by checking for the method's existence before calling it.
>
> Signed-off-by: Avi Kivity <avi@redhat.com>
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2010-05-17 9:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-16 11:59 [Qemu-devel] [PATCH] block: fix aio_flush segfaults for read-only protocols (e.g. curl) Avi Kivity
2010-05-16 13:21 ` Christoph Hellwig
2010-05-17 9:10 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BF107EB.7040709@redhat.com \
--to=kwolf@redhat.com \
--cc=avi@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.